Bug 165650

Potential improvement:

Consider to add
BuildRequires: perl(IO::Socket::SSL)
This enables "https:" checks during "make test"

Non-blocking issues:

1. 
%check || :
The || : is superfluous

2. I'd propose to extend the spec to conditionally support live tests (something
like --with-livetests rsp. %_with_livetests).

(In reply to comment #1)
> Potential improvement:
> 
> Consider to add
> BuildRequires: perl(IO::Socket::SSL)
> This enables "https:" checks during "make test"

Only adds IO::Socket::SSL to the BR list if live tests specified.
 
> Non-blocking issues:
> 
> 1. 
> %check || :
> The || : is superfluous

Removed.


> 2. I'd propose to extend the spec to conditionally support live tests (something
> like --with-livetests rsp. %_with_livetests).

Done.  

Right now the live tests fail. IIRC a couple of months ago they worked.  It
appears that the google pages have changed (different content, missing pages,
...). 


New signed SRPM:
http://gsd.di.uminho.pt/jpo/software/fedora/perl-WWW-Mechanize-1.12-3.src.rpm

APPROVED - Go ahead.

> Right now the live tests fail. IIRC a couple of months ago they worked.
Confirmed. I had packaged WWW-Mechanize a couple of months ago myself and they
all had succeeded. Right now, my old WWW-Mechanize rpm also fails the live test.

> It appears that the google pages have changed.
I just filed http://rt.cpan.org/NoAuth/Bug.html?id=14325

Build fails in mock:
----------
...
t/local/back............# Started http://localhost:32775/
#     Failed test (t/local/back.t at line 148)
#          got: '500'
#     expected: '404'
# Looks like you failed 1 tests of 38.
dubious
	Test returned status 1 (wstat 256, 0x100)
DIED. FAILED test 28
	Failed 1/38 tests, 97.37% okay
...
----------

adding TEST_VERBOSE=1 to the test suite gives:

----------
t/local/back............1..38
ok 1 - use WWW::Mechanize;
ok 2 - The object isa WWW::Mechanize
ok 3 - this $mech starts with a cookie jar
# Started http://localhost:32784/
ok 4 - The object isa LocalServer
...
ok 27 - Pre-404 check
#     Failed test (t/local/back.t at line 148)
not ok 28 - 404 check
#          got: '500'
#     expected: '404'
ok 29 - Even 404s get on the stack
...
ok 38 - No memory cycles found
# Looks like you failed 1 tests of 38.
dubious
        Test returned status 1 (wstat 256, 0x100)
DIED. FAILED test 28
        Failed 1/38 tests, 97.37% okay
----------

No problem when building it locally (FC3 and FC4 systems).

I will try to figure it out during the weekend (it appears that the HTTP server
is given the wrong answer - libwww-perl(HTTP::Daemon,HTTP::Response) related?).

Meanwhile I will build perl-WWW-Mechanize with the test suite disabled as it
only fails one test in mock.

List of failed tests in mock:
 1) t/local/back.t test 28

Update to the new version 1.14:
1) passes all live tests (see also CPAN RT #14325)
2) new live tests build requirement: Test::LongString (t/live/get.t)

https://bugzilla.redhat.com/show_bug.cgi?id=191622 - cweyl implied he's not interested in EPEL, and at todays EPEL meeting Smooge suggested I should just put the requests through.

Package Change Request
======================
Package Name: perl-WWW-Mechanize
New Branches: EL-6
Owners: tremble

cvs done.

Package Change Request
======================
Package Name: perl-WWW-Mechanize
New Branches: EL-5
Owners: ktdreyer
InitialCC: tremble

As discussed in #epel today, tremble will be mentoring me as a co-maintainer for EL-6, and I'll be maintaining WWW::Mech for EL-5.

Git done (by process-git-requests).