Bug 1656734
| Summary: | The "All Ansible Tower Templates" view in the Tower provider also shows embedded Ansible templates | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Peter McGowan <pmcgowan> | ||||
| Component: | UI - OPS | Assignee: | Harpreet Kataria <hkataria> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Satyajit Bulage <sbulage> | ||||
| Severity: | high | Docs Contact: | Red Hat CloudForms Documentation <cloudforms-docs> | ||||
| Priority: | high | ||||||
| Version: | 5.10.0 | CC: | bmidwood, dmetzger, hkataria, jfrey, jhardy, lavenel, mpovolny, obarenbo, simaishi | ||||
| Target Milestone: | GA | ||||||
| Target Release: | 5.11.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 5.11.0.18 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2019-12-12 13:34:53 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | Ansible | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Attachments: |
|
||||||
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/1b9685720615c82789d8cf3744b691cc6ef80c32 commit 1b9685720615c82789d8cf3744b691cc6ef80c32 Author: Harpreet Kataria <hkataria> AuthorDate: Thu Aug 1 11:29:18 2019 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Thu Aug 1 11:29:18 2019 -0400 Changed model name when showing list of Tower Templates. previously code was passing in model as `ConfigurationScript` that returns all Tower templates, Changed to use `ManageIQ::Providers::AnsibleTower::AutomationManager::ConfigurationScript` so that embedded ansible templates are excluded from the list Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1656734 app/controllers/automation_manager_controller.rb | 4 +- product/views/ManageIQ_Providers_AnsibleTower_AutomationManager_ConfigurationScript.yaml | 82 + spec/controllers/automation_manager_controller_spec.rb | 2 +- 3 files changed, 85 insertions(+), 3 deletions(-) New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk: https://github.com/ManageIQ/manageiq-ui-classic/commit/8d2b53aeb68b974f9cb42d3728193feff9b3f874 commit 8d2b53aeb68b974f9cb42d3728193feff9b3f874 Author: Milan Zázrivec <mzazrivec> AuthorDate: Fri Aug 2 04:53:18 2019 -0400 Commit: Milan Zázrivec <mzazrivec> CommitDate: Fri Aug 2 04:53:18 2019 -0400 Merge pull request #5925 from h-kataria/fix_list_of_ansible_tower_templates Changed model name when showing list of Tower Templates. (cherry picked from commit e440234a4bd3f30ac160d7c2e02a5f1a90d6c50a) https://bugzilla.redhat.com/show_bug.cgi?id=1656734 app/controllers/automation_manager_controller.rb | 4 +- product/views/ManageIQ_Providers_AnsibleTower_AutomationManager_ConfigurationScript.yaml | 82 + spec/controllers/automation_manager_controller_spec.rb | 2 +- 3 files changed, 85 insertions(+), 3 deletions(-) Able to see only Ansible Tower Templates, not the Embedded Ansible entities. Verified Version: 5.11.0.19.20190813184334_ed72c9f Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:4199 |
Created attachment 1511991 [details] Screenshot showing Tower templates Description of problem: The "All Ansible Tower Templates" view in the Tower provider details also erroneously shows templates defined for the embedded Ansible provider as a result of creating playbook services. Version-Release number of selected component (if applicable): 5.10.0.27 How reproducible: Every time Steps to Reproduce: 1. Enable the Embedded Ansible server role, add a repository. 2. Create a playbook service using an embedded Ansible playbook 3. Add an Ansible Tower provider that has some job templates defined. Actual results: In the CloudForms display for the Tower provider job templates, observe both the embedded Ansible templates from the defined services, and the correct Tower provider templates are shown. The Accordian only shows the correct Tower templates (see attached screenshot). Expected results: Only the templates defined in the external Tower provider should be listed. Additional info: