Bug 1656752

Summary:	we do not run pyflakes on fedora
Product:	[oVirt] ovirt-engine	Reporter:	Yedidyah Bar David <didi>
Component:	Build.Make	Assignee:	Nir Levy <nlevy>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Sandro Bonazzola <sbonazzo>
Severity:	low	Docs Contact:
Priority:	medium
Version:	4.2.3	CC:	bugs, lleistne, nlevy
Target Milestone:	ovirt-4.3.2	Flags:	sbonazzo: ovirt-4.3? sbonazzo: planning_ack? sbonazzo: devel_ack+ lleistne: testing_ack+
Target Release:	4.3.2.1
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	ovirt-engine-4.3.2.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-03-26 07:20:48 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	Integration	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Yedidyah Bar David 2018-12-06 09:17:52 UTC

See e.g.:

https://gerrit.ovirt.org/#/c/95252/1

Check comment from 'Jenkins CI' on patchset 1.

el7 failed, fc28 passed. el7 failed because pyflakes found an issue. fc28 didn't run pyflakes.

This has been sitting on my TODO list for a month now, decided to move it here.

Not sure what's the best solution - perhaps try also pyflakes3 and use it if found. Once we do this, perhaps make CI fail if no pyflakes is found - perhaps we want to require fixing such cases immediately and not let them wait months (or years. Not sure when we stopped installing pyflakes on fedora).

Comment 1 Nir Levy 2019-03-06 10:38:15 UTC

Fixed.
Change-Id: Ica025e6c363ac66282cf1b087ade0b92bd4ea130

Jenkins Job fc28:
exported-artifacts/mock_logs/script/stdout_stderr.log
No Warning on 'which /usr/bin/pyflakes'
Passed check: /usr/bin/pyflakes {list of files}

Comment 2 Nir Levy 2019-03-06 10:56:47 UTC

Fixed Bug flow to Modified.

Comment 3 Sandro Bonazzola 2019-03-26 07:20:48 UTC

This bugzilla is included in oVirt 4.3.2 release, published on March 19th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.