Bug 1656752 - we do not run pyflakes on fedora
Summary: we do not run pyflakes on fedora
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Build.Make
Version: 4.2.3
Hardware: Unspecified
OS: Unspecified
medium
low
Target Milestone: ovirt-4.3.2
: 4.3.2.1
Assignee: Nir Levy
QA Contact: Sandro Bonazzola
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-12-06 09:17 UTC by Yedidyah Bar David
Modified: 2019-03-26 07:20 UTC (History)
3 users (show)

Fixed In Version: ovirt-engine-4.3.2.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-03-26 07:20:48 UTC
oVirt Team: Integration
Embargoed:
sbonazzo: ovirt-4.3?
sbonazzo: planning_ack?
sbonazzo: devel_ack+
lleistne: testing_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 98260 0 master MERGED automation: Adjust pyflakes packages for fedora. 2019-03-07 10:05:21 UTC

Description Yedidyah Bar David 2018-12-06 09:17:52 UTC
See e.g.:

https://gerrit.ovirt.org/#/c/95252/1

Check comment from 'Jenkins CI' on patchset 1.

el7 failed, fc28 passed. el7 failed because pyflakes found an issue. fc28 didn't run pyflakes.

This has been sitting on my TODO list for a month now, decided to move it here.

Not sure what's the best solution - perhaps try also pyflakes3 and use it if found. Once we do this, perhaps make CI fail if no pyflakes is found - perhaps we want to require fixing such cases immediately and not let them wait months (or years. Not sure when we stopped installing pyflakes on fedora).

Comment 1 Nir Levy 2019-03-06 10:38:15 UTC
Fixed.
Change-Id: Ica025e6c363ac66282cf1b087ade0b92bd4ea130

Jenkins Job fc28:
exported-artifacts/mock_logs/script/stdout_stderr.log
No Warning on 'which /usr/bin/pyflakes'
Passed check: /usr/bin/pyflakes {list of files}

Comment 2 Nir Levy 2019-03-06 10:56:47 UTC
Fixed Bug flow to Modified.

Comment 3 Sandro Bonazzola 2019-03-26 07:20:48 UTC
This bugzilla is included in oVirt 4.3.2 release, published on March 19th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.