Bug 1658135

Summary: [UPGRADES][14]Fail upgrade if deployment task fails
Product: Red Hat OpenStack Reporter: Yurii Prokulevych <yprokule>
Component: python-tripleoclientAssignee: Jiri Stransky <jstransk>
Status: CLOSED ERRATA QA Contact: Ronnie Rasouli <rrasouli>
Severity: high Docs Contact:
Priority: high    
Version: 14.0 (Rocky)CC: augol, ccamacho, ccopello, hbrock, igallagh, jslagle, jstransk, mburns, pgrist, rheslop, sgolovat, tvignaud
Target Milestone: z1Keywords: TestOnly, Triaged, ZStream
Target Release: 14.0 (Rocky)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-tripleoclient-10.6.1-0.20190117233304.e780899.el7ost Doc Type: Bug Fix
Doc Text:
Previously, an upgrade of director would continue with post-upgrade tasks, even if deployment Ansible tasks had failed. This was due to a missing return code check on deployment tasks, which has been added to correct this behavior.
 Story Points: ---
Clone Of: Environment:
Last Closed: 2019-07-02 20:08:26 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description Yurii Prokulevych 2018-12-11 10:37:32 UTC 
Description of problem:
-----------------------
We need to fail earlier in upgrade process if deployment tasks fail and not continue with upgrade tasks.

Version-Release number of selected component (if applicable):
-------------------------------------------------------------
python-tripleoclient-10.6.1-0.20181010222410.8c8f259.el7ost.noarch

How reproducible:
-----------------
100%


Steps to Reproduce:
-------------------
1. Configure different registries in undercloud.conf and containers-image-prepare-paramaters file
2. Run undercloud upgrade


Actual results:
---------------
Upgrade fails because images ain't downloaded and upgrade tasks expect them


Expected results:
-----------------
Don't start upgrade tasks if deployment one failed
Comment 2 Jiri Stransky 2018-12-11 11:14:56 UTC 
The fix is present in stable/rocky.
Comment 4 Carlos Camacho 2018-12-13 14:54:44 UTC 
This is not a blocker, we just need the PM ack to have this available for zstream.
Comment 16 errata-xmlrpc 2019-07-02 20:08:26 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:1672