Bug 1658373
| Summary: | Default worker memory settings in the WebUI are incorrect and do not match the actual configured memory settings | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Peter McGowan <pmcgowan> | ||||
| Component: | UI - OPS | Assignee: | Harpreet Kataria <hkataria> | ||||
| Status: | CLOSED CURRENTRELEASE | QA Contact: | Jaroslav Henner <jhenner> | ||||
| Severity: | high | Docs Contact: | Red Hat CloudForms Documentation <cloudforms-docs> | ||||
| Priority: | high | ||||||
| Version: | 5.10.0 | CC: | bmidwood, brant.evans, dmetzger, hkataria, lavenel, mpovolny, obarenbo, pmcgowan, simaishi | ||||
| Target Milestone: | GA | Keywords: | TestOnly, ZStream | ||||
| Target Release: | 5.11.0 | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | 5.11.0.1 | Doc Type: | If docs needed, set a value | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | |||||||
| : | 1686902 (view as bug list) | Environment: | |||||
| Last Closed: | 2019-12-13 14:55:05 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | CFME Core | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1686902 | ||||||
| Attachments: |
|
||||||
|
Description
Peter McGowan
2018-12-11 21:34:49 UTC
New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/6a20b57e7b6268ff14c43f778b48ced5387568bf commit 6a20b57e7b6268ff14c43f778b48ced5387568bf Author: Harpreet Kataria <hkataria> AuthorDate: Wed Jan 23 18:37:31 2019 -0500 Commit: Harpreet Kataria <hkataria> CommitDate: Wed Jan 23 18:37:31 2019 -0500 Fixed display of worker memory threshold settings Fixed couple of scenarios - Worker memory threshold of 1 GB or above was not reflected on Workers tab because https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/ops_controller/settings/common.rb#L997 value of variable `x` needs to be converted to integer value from a float so value can be selected correctly in the drop down. - If a value in yaml config file is set to as 600.megabytes, it is being returned as a string, so need to evaluate/convert the value so it can be correctly selected in the drop down. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1656873 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1658373 app/controllers/ops_controller/settings/common.rb | 6 +- spec/controllers/ops_controller/settings/common_spec.rb | 37 + 2 files changed, 40 insertions(+), 3 deletions(-) New commit detected on ManageIQ/manageiq-ui-classic/hammer: https://github.com/ManageIQ/manageiq-ui-classic/commit/142b265e8d0cbc2e9e650d11c8a43e09c38258ff commit 142b265e8d0cbc2e9e650d11c8a43e09c38258ff Author: Harpreet Kataria <hkataria> AuthorDate: Wed Jan 23 18:37:31 2019 -0500 Commit: Harpreet Kataria <hkataria> CommitDate: Wed Jan 23 18:37:31 2019 -0500 Fixed display of worker memory threshold settings Fixed couple of scenarios - Updated code to use `get_worker_setting` method - Worker memory threshold of 1 GB or above was not reflected on Workers tab because https://github.com/ManageIQ/manageiq-ui-classic/blob/master/app/controllers/ops_controller/settings/common.rb#L997 value of variable `x` needs to be converted to integer value from a float so value can be selected correctly in the drop down. - If a value in yaml config file is set to as 600.megabytes, it is being returned as a string, so need to evaluate/convert the value so it can be correctly selected in the drop down. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1656873 Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1658373 (cherry picked from commit 6a20b57e7b6268ff14c43f778b48ced5387568bf) app/controllers/ops_controller/settings/common.rb | 57 +- spec/controllers/ops_controller/settings/common_spec.rb | 37 + 2 files changed, 68 insertions(+), 26 deletions(-) New commit detected on ManageIQ/manageiq-ui-classic/master: https://github.com/ManageIQ/manageiq-ui-classic/commit/e1f3c405fe2e01a26b6a68eccbb01813da19e53e commit e1f3c405fe2e01a26b6a68eccbb01813da19e53e Author: Harpreet Kataria <hkataria> AuthorDate: Thu Mar 28 10:51:05 2019 -0400 Commit: Harpreet Kataria <hkataria> CommitDate: Thu Mar 28 10:51:05 2019 -0400 Fixed display of default memory threshold correctly on new appliance Memory Threshold value of C & U Data Collectors, Refresh, VM Analysis Collectors workers on fresh appliance was not showing correctly. - Changed range calculation in the .step that sets the values for the drop down, to fix the issue where in rails the default config value of 2.gigabytes is converted to 2147483648 but the calculations in the .step method was generating that as 2147483644 causing the values to not match and not display the right one selected in the drop down. - Fixed the fetching of worker setting for MiqEmsMetricsCollectorWorker worker to be the same format as other workers. - Added additional value in VM Analysis Collectors drop down, because default for that in config is set to 2.gigabytes and drop down did not have that value present. Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1658373 app/controllers/ops_controller/settings/common.rb | 18 +- spec/controllers/ops_controller/settings/common_spec.rb | 8 + 2 files changed, 17 insertions(+), 9 deletions(-) I changed the Priority worker memory and the change did propagate to the advanced config. |