Bug 1658742

Summary: Inconsistent type for 'remote-port' parameter
Product: [Community] GlusterFS Reporter: Yaniv Kaul <ykaul>
Component: rpcAssignee: Milind Changire <mchangir>
Status: CLOSED DEFERRED QA Contact:
Severity: low Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, pasik, rgowdapp
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-07-01 06:14:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Yaniv Kaul 2018-12-12 19:06:53 UTC 
Description of problem:
It seems to be set as int32, and read as uint16.

Elsewhere, it is used as a string, which is even stranger, btw.

It should be consistent.

For example:
api/src/glfs-mgmt.c:923:                    ret = dict_set_int32(rpc_trans->options, "remote-port",
rpc/rpc-transport/socket/src/name.c:242:        remote_port = data_to_uint16(remote_port_data);
rpc/rpc-transport/rdma/src/name.c:245:            remote_port = data_to_uint16(remote_port_data);
rpc/rpc-lib/src/rpc-transport.c:684:    ret = dict_set_int32(dict, "remote-port", port);
Comment 1 Yaniv Kaul 2019-07-01 06:14:31 UTC 
Still relevant, as of Gluster 7, but doesn't seem like anyone is going to fix this, closing.