Bug 1658742 - Inconsistent type for 'remote-port' parameter
Summary: Inconsistent type for 'remote-port' parameter
Keywords:
Status: CLOSED DEFERRED
Alias: None
Product: GlusterFS
Classification: Community
Component: rpc
Version: mainline
Hardware: Unspecified
OS: Unspecified
unspecified
low
Target Milestone: ---
Assignee: Milind Changire
QA Contact:
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-12-12 19:06 UTC by Yaniv Kaul
Modified: 2019-07-01 06:14 UTC (History)
3 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-07-01 06:14:31 UTC
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Embargoed:


Attachments (Terms of Use)

Description Yaniv Kaul 2018-12-12 19:06:53 UTC
Description of problem:
It seems to be set as int32, and read as uint16.

Elsewhere, it is used as a string, which is even stranger, btw.

It should be consistent.

For example:
api/src/glfs-mgmt.c:923:                    ret = dict_set_int32(rpc_trans->options, "remote-port",
rpc/rpc-transport/socket/src/name.c:242:        remote_port = data_to_uint16(remote_port_data);
rpc/rpc-transport/rdma/src/name.c:245:            remote_port = data_to_uint16(remote_port_data);
rpc/rpc-lib/src/rpc-transport.c:684:    ret = dict_set_int32(dict, "remote-port", port);

Comment 1 Yaniv Kaul 2019-07-01 06:14:31 UTC
Still relevant, as of Gluster 7, but doesn't seem like anyone is going to fix this, closing.


Note You need to log in before you can comment on or make changes to this bug.