Bug 1658880
| Summary: | [virtio-win][viostor] viostor driver format is incorrect in virtio-win-prewhql-0.1-163 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 8 | Reporter: | Yanan Fu <yfu> | ||||||||
| Component: | virtio-win | Assignee: | Vadim Rozenfeld <vrozenfe> | ||||||||
| virtio-win sub component: | virtio-win-prewhql | QA Contact: | lijin <lijin> | ||||||||
| Status: | CLOSED NOTABUG | Docs Contact: | |||||||||
| Severity: | high | ||||||||||
| Priority: | high | CC: | ailan, chayang, ddepaula, jinzhao, juzhang, knoel, lijin, michen, mtessun, mxie, virt-bugs, vrozenfe, yfu, ymankad | ||||||||
| Version: | 8.0 | Keywords: | Regression | ||||||||
| Target Milestone: | rc | ||||||||||
| Target Release: | 8.0 | ||||||||||
| Hardware: | x86_64 | ||||||||||
| OS: | Windows | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2019-03-12 08:40:05 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | 1633087 | ||||||||||
| Bug Blocks: | 1659244 | ||||||||||
| Attachments: |
|
||||||||||
The changes in viostor.inf file were introduced as a fix for Bug 1633087 - [virtio-win] incorrect virtio-win driver version shown in sigverif log file The problem is that some of internal Windows tools expect to see *.inf files UNICODE coded. Most, if not all in-box *.inf file provided by MS are UNICODE because they need to support localisation. I need to know if turning *.inf to UNICODE is going to be a problem to QE and/or other teams ( v2v conversion, RPM packaging, etc,.) ? Thanks, Vadim. (In reply to Vadim Rozenfeld from comment #2) > The changes in viostor.inf file were introduced as a fix for Bug 1633087 - > [virtio-win] incorrect virtio-win driver version shown in sigverif log file > The problem is that some of internal Windows tools expect to see *.inf files > UNICODE coded. Most, if not all in-box *.inf file provided by MS are UNICODE > because they need to support localisation. > > I need to know if turning *.inf to UNICODE is going to be a problem to QE > and/or other teams ( v2v conversion, RPM packaging, etc,.) ? For now, it only affect our automation jobs(we use findstr to verify the driver version). If UNICODE is a must, I think we can find a working way :-) For v2v conversion, and rpm packaging, I don't know if there will be any problem honestly. I will needinfo someone might know about it. btw, will all virtio-win drivers turn into UNICODE? Hi Danilo,mxie Could you help to answer questions in comment#2 as well? Thanks (In reply to lijin from comment #3) > (In reply to Vadim Rozenfeld from comment #2) > > The changes in viostor.inf file were introduced as a fix for Bug 1633087 - > > [virtio-win] incorrect virtio-win driver version shown in sigverif log file > > The problem is that some of internal Windows tools expect to see *.inf files > > UNICODE coded. Most, if not all in-box *.inf file provided by MS are UNICODE > > because they need to support localisation. > > > > I need to know if turning *.inf to UNICODE is going to be a problem to QE > > and/or other teams ( v2v conversion, RPM packaging, etc,.) ? > > For now, it only affect our automation jobs(we use findstr to verify the > driver version). > If UNICODE is a must, I think we can find a working way :-) > > For v2v conversion, and rpm packaging, I don't know if there will be any > problem honestly. > I will needinfo someone might know about it. > > btw, will all virtio-win drivers turn into UNICODE? I'm not sure yet if UNICODE is a must to solve bz#1633087. But is yes, we need to be prepared to see some side effects. Test with virtio-win-1.9.6-6.el8.noarch Convert a win2019 guest to rhv by virt-v2v. all virtio drivers install in guest normally after conversion, and can't reproduce the bug after checking, pls refer to screenshot"win2019-v2v" Created attachment 1514310 [details]
win2019-v2v
(In reply to mxie from comment #6) > Test with virtio-win-1.9.6-6.el8.noarch > > Convert a win2019 guest to rhv by virt-v2v. all virtio drivers install in > guest normally after conversion, and can't reproduce the bug after checking, > pls refer to screenshot"win2019-v2v" Thanks, mxie. But this issue is new introduced in virtio-win-prewhql-0.1-163: https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=812055 If an iso in needed, please check http://fileshare.englab.nay.redhat.com/pub/section2/images_backup/virtio-win/bug1658880/virtio-win-prewhql-0.1-163.iso Test with virtio-win-prewhql-0.1.zip, can install virtio driver for disk normally in win2019 guest, pls refer to screenshot "win2019-virtio-win-prewhql-0.1.png" Created attachment 1517040 [details]
win2019-virtio-win-prewhql-0.1.png
Hi vadim, Is this still a valid bug? If not, maybe we can close it. (In reply to lijin from comment #16) > Hi vadim, > > Is this still a valid bug? If not, maybe we can close it. Let's close it. We can reopen it later on if we see any need to introduce UNICODE in .inf files. Best regards, Vadim. close it according to comment#17 |
Created attachment 1513896 [details] The output of 'findtr' in guest. Description of problem: The format of viostor driver in virtio-win-prewhql-0.1-163 is not normal. Can not get "DriverVer" from viostor.inf. 1. C:\Users\Administrator>findstr "DriverVer=" Desktop\virtio-win-prewhql-0.1-163\Win10\amd64\viostor.inf --> can not find the string. 2. C:\Users\Administrator>findstr "DriverVer=" Desktop\virtio-win-prewhql-0.1-163\Win10\amd64\vioscsi.inf DriverVer=12/10/2018,100.77.104.16300 --> get given string. 3. C:\Users\Administrator>findstr "D r i v e r" Desktop\virtio-win-prewhql-0.1-163\Win10\amd64\viostor.inf Add the output in attachment, there is one space after each character. This is a regression problem: 1. virtio-win-prewhql-0.1-162 is ok. 2. only viostor has this problem, other drivers are ok. 3. No related with guest, viostor at every guest folders all have this problem. Version-Release number of selected component (if applicable): virtio-win-prewhql-0.1-163 How reproducible: 100% Steps to Reproduce: 1. 2. 3. Actual results: Expected results: Additional info: