RHEL Engineering is moving the tracking of its product development work on RHEL 6 through RHEL 9 to Red Hat Jira (issues.redhat.com). If you're a Red Hat customer, please continue to file support cases via the Red Hat customer portal. If you're not, please head to the "RHEL project" in Red Hat Jira and file new tickets here. Individual Bugzilla bugs in the statuses "NEW", "ASSIGNED", and "POST" are being migrated throughout September 2023. Bugs of Red Hat partners with an assigned Engineering Partner Manager (EPM) are migrated in late September as per pre-agreed dates. Bugs against components "kernel", "kernel-rt", and "kpatch" are only migrated if still in "NEW" or "ASSIGNED". If you cannot log in to RH Jira, please consult article #7032570. That failing, please send an e-mail to the RH Jira admins at rh-issues@redhat.com to troubleshoot your issue as a user management inquiry. The email creates a ServiceNow ticket with Red Hat. Individual Bugzilla bugs that are migrated will be moved to status "CLOSED", resolution "MIGRATED", and set with "MigratedToJIRA" in "Keywords". The link to the successor Jira issue will be found under "Links", have a little "two-footprint" icon next to it, and direct you to the "RHEL project" in Red Hat Jira (issue links are of type "https://issues.redhat.com/browse/RHEL-XXXX", where "X" is a digit). This same link will be available in a blue banner at the top of the page informing you that that bug has been migrated.
Bug 1658880 - [virtio-win][viostor] viostor driver format is incorrect in virtio-win-prewhql-0.1-163
Summary: [virtio-win][viostor] viostor driver format is incorrect in virtio-win-prewhq...
Keywords:
Status: CLOSED NOTABUG
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: virtio-win
Version: 8.0
Hardware: x86_64
OS: Windows
high
high
Target Milestone: rc
: 8.0
Assignee: Vadim Rozenfeld
QA Contact: lijin
URL:
Whiteboard:
Depends On: 1633087
Blocks: 1659244
TreeView+ depends on / blocked
 
Reported: 2018-12-13 05:12 UTC by Yanan Fu
Modified: 2023-02-10 18:55 UTC (History)
14 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-03-12 08:40:05 UTC
Type: Bug
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)
The output of 'findtr' in guest. (5.36 KB, text/plain)
2018-12-13 05:12 UTC, Yanan Fu 		no flags Details
win2019-v2v (26.42 KB, image/png)
2018-12-14 08:21 UTC, mxie@redhat.com 		no flags Details
win2019-virtio-win-prewhql-0.1.png (93.24 KB, image/png)
2018-12-27 11:17 UTC, mxie@redhat.com 		no flags Details
View All

Description Yanan Fu 2018-12-13 05:12:05 UTC 
Created attachment 1513896 [details]
The output of 'findtr' in guest.

Description of problem:
The format of viostor driver in virtio-win-prewhql-0.1-163 is not normal.
Can not get "DriverVer" from viostor.inf.

1. C:\Users\Administrator>findstr "DriverVer=" Desktop\virtio-win-prewhql-0.1-163\Win10\amd64\viostor.inf   --> can not find the string.

2. C:\Users\Administrator>findstr "DriverVer=" Desktop\virtio-win-prewhql-0.1-163\Win10\amd64\vioscsi.inf
DriverVer=12/10/2018,100.77.104.16300   --> get given string.

3. C:\Users\Administrator>findstr "D r i v e r" Desktop\virtio-win-prewhql-0.1-163\Win10\amd64\viostor.inf
Add the output in attachment, there is one space after each character.


This is a regression problem:
1. virtio-win-prewhql-0.1-162 is ok.
2. only viostor has this problem, other drivers are ok.
3. No related with guest, viostor at every guest folders all have this problem. 

Version-Release number of selected component (if applicable):
virtio-win-prewhql-0.1-163 

How reproducible:
100%

Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:
Comment 2 Vadim Rozenfeld 2018-12-14 02:17:21 UTC 
The changes in viostor.inf file were introduced as a fix for Bug 1633087 - [virtio-win] incorrect virtio-win driver version shown in sigverif log file
The problem is that some of internal Windows tools expect to see *.inf files UNICODE coded. Most, if not all in-box *.inf file provided by MS are UNICODE
because they need to support localisation.

I need to know if turning *.inf to UNICODE is going to be a problem to QE and/or other teams ( v2v conversion, RPM packaging, etc,.) ?

Thanks,
Vadim.
Comment 3 lijin 2018-12-14 06:38:31 UTC 
(In reply to Vadim Rozenfeld from comment #2)
> The changes in viostor.inf file were introduced as a fix for Bug 1633087 -
> [virtio-win] incorrect virtio-win driver version shown in sigverif log file
> The problem is that some of internal Windows tools expect to see *.inf files
> UNICODE coded. Most, if not all in-box *.inf file provided by MS are UNICODE
> because they need to support localisation.
> 
> I need to know if turning *.inf to UNICODE is going to be a problem to QE
> and/or other teams ( v2v conversion, RPM packaging, etc,.) ?

For now, it only affect our automation jobs(we use findstr to verify the driver version).
If UNICODE is a must, I think we can find a working way :-)

For v2v conversion, and rpm packaging, I don't know if there will be any problem honestly.
I will needinfo someone might know about it.

btw, will all virtio-win drivers turn into UNICODE?
Comment 4 lijin 2018-12-14 06:42:22 UTC 
Hi Danilo,mxie

Could you help to answer questions in comment#2 as well? 

Thanks
Comment 5 Vadim Rozenfeld 2018-12-14 07:55:16 UTC 
(In reply to lijin from comment #3)
> (In reply to Vadim Rozenfeld from comment #2)
> > The changes in viostor.inf file were introduced as a fix for Bug 1633087 -
> > [virtio-win] incorrect virtio-win driver version shown in sigverif log file
> > The problem is that some of internal Windows tools expect to see *.inf files
> > UNICODE coded. Most, if not all in-box *.inf file provided by MS are UNICODE
> > because they need to support localisation.
> > 
> > I need to know if turning *.inf to UNICODE is going to be a problem to QE
> > and/or other teams ( v2v conversion, RPM packaging, etc,.) ?
> 
> For now, it only affect our automation jobs(we use findstr to verify the
> driver version).
> If UNICODE is a must, I think we can find a working way :-)
> 
> For v2v conversion, and rpm packaging, I don't know if there will be any
> problem honestly.
> I will needinfo someone might know about it.
> 
> btw, will all virtio-win drivers turn into UNICODE?

I'm not sure yet if UNICODE is a must to solve bz#1633087. But is yes, we need
to be prepared to see some side effects.
Comment 6 mxie@redhat.com 2018-12-14 08:15:01 UTC 
Test with virtio-win-1.9.6-6.el8.noarch

Convert a win2019 guest to rhv by virt-v2v. all virtio drivers install in guest normally after conversion, and can't reproduce the bug after checking, pls refer to screenshot"win2019-v2v"
Comment 7 mxie@redhat.com 2018-12-14 08:21:42 UTC 
Created attachment 1514310 [details]
win2019-v2v
Comment 8 lijin 2018-12-17 01:30:09 UTC 
(In reply to mxie from comment #6)
> Test with virtio-win-1.9.6-6.el8.noarch
> 
> Convert a win2019 guest to rhv by virt-v2v. all virtio drivers install in
> guest normally after conversion, and can't reproduce the bug after checking,
> pls refer to screenshot"win2019-v2v"

Thanks, mxie.
But this issue is new introduced in virtio-win-prewhql-0.1-163: https://brewweb.engineering.redhat.com/brew/buildinfo?buildID=812055
If an iso in needed, please check http://fileshare.englab.nay.redhat.com/pub/section2/images_backup/virtio-win/bug1658880/virtio-win-prewhql-0.1-163.iso
Comment 11 mxie@redhat.com 2018-12-27 11:13:38 UTC 
Test with virtio-win-prewhql-0.1.zip, can install virtio driver for disk normally in win2019 guest, pls refer to screenshot "win2019-virtio-win-prewhql-0.1.png"
Comment 12 mxie@redhat.com 2018-12-27 11:17:43 UTC 
Created attachment 1517040 [details]
win2019-virtio-win-prewhql-0.1.png
Comment 16 lijin 2019-03-12 06:05:09 UTC 
Hi vadim,

Is this still a valid bug? If not, maybe we can close it.
Comment 17 Vadim Rozenfeld 2019-03-12 08:30:42 UTC 
(In reply to lijin from comment #16)
> Hi vadim,
> 
> Is this still a valid bug? If not, maybe we can close it.

Let's close it. We can reopen it later on if we see any need to
introduce UNICODE in .inf files.

Best regards,
Vadim.
Comment 18 lijin 2019-03-12 08:40:05 UTC 
close it according to comment#17
Note You need to log in before you can comment on or make changes to this bug.