Bug 1659071

Summary: [RFE] [qemu-ga] Add "windows 2019 x64" support to OS reporting
Product: Red Hat Enterprise Linux 8 Reporter: Michal Skrivanek <michal.skrivanek>
Component: virtio-winAssignee: Yvugenfi <yvugenfi>
virtio-win sub component: qemu-ga-win QA Contact: xiagao
Status: CLOSED CURRENTRELEASE Docs Contact:
Severity: unspecified    
Priority: unspecified CC: ailan, chayang, ddepaula, jen, juzhang, lijin, mjankula, mtessun, tgolembi, xiagao, yvugenfi
Version: 8.0Keywords: FutureFeature
Target Milestone: rcFlags: pm-rhel: mirror+
Target Release: 8.0   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-06-14 01:20:02 UTC Type: Feature Request
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1655503, 1659244    

Description Michal Skrivanek 2018-12-13 14:05:03 UTC
Windows qemu-ga should report Windows 2019 in osinfo, see bug 1563004 for details

Comment 3 Sameeh Jubran 2018-12-19 16:02:52 UTC
A patch which implements this functionality was sent upstream and applied to downstream:

https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg04800.html

build:
http://brew-task-repos.usersys.redhat.com/repos/scratch/sjubran/mingw-qemu-ga-win/7.6.2/3.el7ev/

Comment 7 xiagao 2018-12-20 09:53:48 UTC
Test with this build, can get correct win2019 guest os info.
result:

{"execute": "guest-get-osinfo"}
{"return": {"name": "Microsoft Windows", "kernel-release": "17763", "version": "Microsoft Windows Server 2019", "variant": "server", "pretty-name": "Windows Server 2019 Datacenter", "version-id": "2019", "variant-id": "server", "kernel-version": "10.0", "machine": "x86_64", "id": "mswindows"}}

Comment 9 lijin 2018-12-26 03:00:42 UTC
Hi Amnon, Sammeh,

The provided package(mingw-qemu-ga-win-7.6.2-3.el7ev) is for rhel7, should we generate one for rhel8?

Comment 15 Danilo de Paula 2019-01-02 19:17:43 UTC
Only one version is better from packaging point of view.

Comment 16 lijin 2019-01-10 02:31:16 UTC
Hi Amnon, Yan,

What's the plan about version issue?

Comment 21 xiagao 2019-01-23 06:17:28 UTC
Test with mingw-qemu-ga-win-100.0.0.0-3.el7ev, can get correct win2019 guest os info.
result:

{"execute":"guest-get-osinfo"}
{"return": {"name": "Microsoft Windows", "kernel-release": "17763", "version": "Microsoft Windows Server 2019", "variant": "server", "pretty-name": "Windows Server 2019 Datacenter", "version-id": "2019", "variant-id": "server", "kernel-version": "10.0", "machine": "x86_64", "id": "mswindows"}}

Change the bug status to verified.