Bug 1660123
Summary: | No spice channel is added for Windows guests | ||
---|---|---|---|
Product: | Red Hat Enterprise Linux 8 | Reporter: | Radek Duda <rduda> |
Component: | virt-manager | Assignee: | Pavel Hrdina <phrdina> |
Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> |
Severity: | high | Docs Contact: | |
Priority: | high | ||
Version: | 8.0 | CC: | crobinso, jherrman, juzhou, kkoukiou, knoel, mtessun, mxie, mzhan, tzheng, xiaodwan, zili |
Target Milestone: | rc | Keywords: | Regression |
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | virt-manager-2.2.0-1.el8 | Doc Type: | If docs needed, set a value |
Doc Text: | Story Points: | --- | |
Clone Of: | 1653698 | Environment: | |
Last Closed: | 2019-11-05 21:19:13 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1653698 | ||
Bug Blocks: |
Description
Radek Duda
2018-12-17 14:48:43 UTC
Thanks for opening the RHEL bug, it's worth discussing. My comment above basically covers it, but it's not clear to me if attaching spice channel by default is better or worse. Granted no one complained up until this point so maybe it's just safer to go back, but since installing virtio drivers with virt-manager is a manual process anyways it's not too much to ask of users to manually add the spice channel as well. I'm interested in what others think Martin, Any comment whether this should be fixed or not? Does this require a doc change? Thanks. (In reply to Karen Noel from comment #2) > Martin, Any comment whether this should be fixed or not? Does this require a > doc change? Thanks. I believe we should document this in the user story for Windows guest. @Jirka - Fine with you? (In reply to Cole Robinson from comment #1) > Thanks for opening the RHEL bug, it's worth discussing. My comment above > basically covers it, but it's not clear to me if attaching spice channel by > default is better or worse. Granted no one complained up until this point so > maybe it's just safer to go back, but since installing virtio drivers with > virt-manager is a manual process anyways it's not too much to ask of users > to manually add the spice channel as well. I'm interested in what others > think There was one complain about it on IRC channel that virt-manager no longer adds spice channel by default into windows guest. Yes, it requires manual step that you need to install drivers for it so I can understand the motivation to remove it from default devices, however, I would rather revert this change and made it default again. Before this change it was fairly easy to get all the functionality with windows guests, you would just install new guest from scratch, downloaded spice-guest-tools and install all the drivers and everything worked. Now you need to add the device manually which IMHO makes things worse. (In reply to Pavel Hrdina from comment #7) > > There was one complain about it on IRC channel that virt-manager no longer > adds > spice channel by default into windows guest. Yes, it requires manual step > that > you need to install drivers for it so I can understand the motivation to > remove > it from default devices, however, I would rather revert this change and made > it > default again. > > Before this change it was fairly easy to get all the functionality with > windows > guests, you would just install new guest from scratch, downloaded > spice-guest-tools > and install all the drivers and everything worked. Now you need to add the > device > manually which IMHO makes things worse. Fine by me, let's add it back This is back upstream now commit d40975c493a554d179cca1c5c888cacfc2c9cd41 (HEAD -> master, origin/master) Author: Cole Robinson <crobinso> Date: Fri Jun commit d40975c493a554d179cca1c5c888cacfc2c9cd41 (HEAD -> master, origin/master) Author: Cole Robinson <crobinso> Date: Fri Jun 14 20:51:43 2019 -0400 guest: Add back spice virtio-serial for windows 14 20:51:43 2019 -0400 guest: Add back spice virtio-serial for windows I can reproduce this issue with package: virt-manager-2.0.0-5.el8.noarch Then try to verify this package with build: virt-manager-2.2.1-1.el8.noarch libvirt-4.5.0-30.module+el8.1.0+3574+3a63752b.x86_64 qemu-kvm-2.12.0-82.module+el8.1.0+3738+0d8c0249.x86_64 python3-libvirt-4.5.0-2.module+el8.1.0+3531+2918145b.x86_64 Steps: 1. Click 'Create new virtual machine' in virt-manager GUI 2. In step 2 choose 'Microsoft Windows 10'. 3. Proceed until click 'Finish' button Result: Spice channel is added to Windows VM. # virsh dumpxml win10 ... <channel type='spicevmc'> <target type='virtio' name='com.redhat.spice.0' state='disconnected'/> <alias name='channel0'/> <address type='virtio-serial' controller='0' bus='0' port='1'/> </channel> ... And it also works when i install win2k16 and win2k19, so I move this bug from ON_QA to VERIFIED. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHSA-2019:3464 |