Bug 166059

Summary: Review Request: perl-Class-Container
Product: [Fedora] Fedora Reporter: Steven Pritchard <steve>
Component: Package ReviewAssignee: Greg DeKoenigsberg <gdk>
Status: CLOSED NEXTRELEASE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://ftp.kspei.com/pub/steve/rpms/perl-Class-Container-0.12-1.src.rpm
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-08-21 00:49:49 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779, 166063    
Attachments:
Description Flags
Proposed spec patch none

Description Steven Pritchard 2005-08-16 14:23:34 UTC 
Spec Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Class-Container/perl-Class-Container.spec
SRPM Name or Url: http://ftp.kspei.com/pub/steve/rpms/perl-Class-Container-0.12-1.src.rpm
Description:
This class facilitates building frameworks of several classes that
inter-operate. It was first designed and built for "HTML::Mason", in
which the Compiler, Lexer, Interpreter, Resolver, Component, Buffer, and
several other objects must create each other transparently, passing the
appropriate parameters to the right class, possibly substituting other
subclasses for any of these objects.

The main features of "Class::Container" are:

*   Explicit declaration of containment relationships (aggregation,
    factory creation, etc.)

*   Declaration of constructor parameters accepted by each member in a
    class framework

*   Transparent passing of constructor parameters to the class that
    needs them

*   Ability to create one (automatic) or many (manual) contained objects
    automatically and transparently
Comment 1 Ralf Corsepius 2005-08-16 14:59:14 UTC 
Created attachment 117790 [details]
Proposed spec patch
Comment 2 Ralf Corsepius 2005-08-16 15:00:57 UTC 
Package looks fine, source match cpan, ...

Some minor nits:
- The LD_RUN_PATH "sed" isn't necessary.
- %check ||:
- Explicitly setting perl_vendorlib isn't necessary since FC3

I'd approve the package with the patch from the attachment applied.
Comment 3 Steven Pritchard 2005-08-17 22:46:30 UTC 
Done, and checked into CVS.  Approved?
Comment 4 Ralf Corsepius 2005-08-18 01:33:53 UTC 
Yep.