Bug 166182

Summary: Review Request: perl-CGI-Untaint-date : Validate a date
Product: [Fedora] Fedora Reporter: Tom "spot" Callaway <tcallawa>
Component: Package ReviewAssignee: Paul Howarth <paul>
Status: CLOSED NEXTRELEASE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://search.cpan.org/dist/CGI-Untaint-date/
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-09-07 19:07:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 166181, 166567    
Bug Blocks: 163779, 166203    
Attachments:
Description Flags
Patch addressing review issues none

Description Tom "spot" Callaway 2005-08-17 20:13:12 UTC
Spec Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-CGI-Untaint-date.spec
SRPM Name or Url: 
http://www.auroralinux.org/people/spot/review/Maypole/perl-CGI-Untaint-date-0.03-2.src.rpm

Description: 

Validate a date

(NOTE: This package is one of the Maypole dependencies)

Comment 1 Paul Howarth 2005-08-23 14:22:48 UTC
Created attachment 118002 [details]
Patch addressing review issues

Review:

- rpmlint clean
- package and spec file name OK
- package meets guidelines
- license same as perl, tag correct in spec
- spec written in English and is legible
- source matches upstream
- package builds (when fixed) OK in mock on FC4 (i386)
- no locales, libraries, subpackages, pkgconfigs etc. to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets

Needswork:
- missing BR: perl(Date::Simple) >= 0.01
- missing BR: perl(Date::Manip) >= 5
- Makefile.PL suggests versioned BR: perl(CGI::Untaint) >= 0.07
- perhaps Requires: need versioning too?
- license text not included; suggest adding to %setup:
  perldoc -t perlgpl > COPYING
  perldoc -t perlartistic > Artistic
  and to %files:
  %doc COPYING Artistic
- redundant BR: perl

Attached patch fixes these issues.

Comment 2 Paul Howarth 2005-08-23 14:46:47 UTC
Another thing:

- make called without %{_smp_mflags}

(not addressed by patch)

Comment 3 Matthias Saou 2005-08-23 14:58:44 UTC
That should always be %{?_smp_mflags}, otherwise the build will fail when
_smp_mflags isn't defined.

Comment 4 Tom "spot" Callaway 2005-08-23 15:34:34 UTC
All changes incorporated (both from patch and ?_smp_mflags) in -3.

New SRPM:
http://www.auroralinux.org/people/spot/review/Maypole/perl-CGI-Untaint-date-0.03-3.src.rpm

New SPEC:
http://www.auroralinux.org/people/spot/review/Maypole/perl-CGI-Untaint-date.spec

Of course, we now depend on perl-Date-Simple, so this review depends on bugzilla
166579.

Comment 5 Paul Howarth 2005-08-23 17:14:11 UTC
Looks good.

Approved.