Spec Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-CGI-Untaint-date.spec SRPM Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-CGI-Untaint-date-0.03-2.src.rpm Description: Validate a date (NOTE: This package is one of the Maypole dependencies)
Created attachment 118002 [details] Patch addressing review issues Review: - rpmlint clean - package and spec file name OK - package meets guidelines - license same as perl, tag correct in spec - spec written in English and is legible - source matches upstream - package builds (when fixed) OK in mock on FC4 (i386) - no locales, libraries, subpackages, pkgconfigs etc. to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no scriptlets Needswork: - missing BR: perl(Date::Simple) >= 0.01 - missing BR: perl(Date::Manip) >= 5 - Makefile.PL suggests versioned BR: perl(CGI::Untaint) >= 0.07 - perhaps Requires: need versioning too? - license text not included; suggest adding to %setup: perldoc -t perlgpl > COPYING perldoc -t perlartistic > Artistic and to %files: %doc COPYING Artistic - redundant BR: perl Attached patch fixes these issues.
Another thing: - make called without %{_smp_mflags} (not addressed by patch)
That should always be %{?_smp_mflags}, otherwise the build will fail when _smp_mflags isn't defined.
All changes incorporated (both from patch and ?_smp_mflags) in -3. New SRPM: http://www.auroralinux.org/people/spot/review/Maypole/perl-CGI-Untaint-date-0.03-3.src.rpm New SPEC: http://www.auroralinux.org/people/spot/review/Maypole/perl-CGI-Untaint-date.spec Of course, we now depend on perl-Date-Simple, so this review depends on bugzilla 166579.
Looks good. Approved.