Bug 166182 - Review Request: perl-CGI-Untaint-date : Validate a date
Review Request: perl-CGI-Untaint-date : Validate a date
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Paul Howarth
David Lawrence
Depends On: 166181 166567
Blocks: FE-ACCEPT 166203
  Show dependency treegraph
Reported: 2005-08-17 16:13 EDT by Tom "spot" Callaway
Modified: 2007-11-30 17:11 EST (History)
1 user (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2005-09-07 15:07:55 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)
Patch addressing review issues (1.50 KB, patch)
2005-08-23 10:22 EDT, Paul Howarth
no flags Details | Diff

  None (edit)
Description Tom "spot" Callaway 2005-08-17 16:13:12 EDT
Spec Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-CGI-Untaint-date.spec
SRPM Name or Url: 


Validate a date

(NOTE: This package is one of the Maypole dependencies)
Comment 1 Paul Howarth 2005-08-23 10:22:48 EDT
Created attachment 118002 [details]
Patch addressing review issues


- rpmlint clean
- package and spec file name OK
- package meets guidelines
- license same as perl, tag correct in spec
- spec written in English and is legible
- source matches upstream
- package builds (when fixed) OK in mock on FC4 (i386)
- no locales, libraries, subpackages, pkgconfigs etc. to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets

- missing BR: perl(Date::Simple) >= 0.01
- missing BR: perl(Date::Manip) >= 5
- Makefile.PL suggests versioned BR: perl(CGI::Untaint) >= 0.07
- perhaps Requires: need versioning too?
- license text not included; suggest adding to %setup:
  perldoc -t perlgpl > COPYING
  perldoc -t perlartistic > Artistic
  and to %files:
  %doc COPYING Artistic
- redundant BR: perl

Attached patch fixes these issues.
Comment 2 Paul Howarth 2005-08-23 10:46:47 EDT
Another thing:

- make called without %{_smp_mflags}

(not addressed by patch)
Comment 3 Matthias Saou 2005-08-23 10:58:44 EDT
That should always be %{?_smp_mflags}, otherwise the build will fail when
_smp_mflags isn't defined.
Comment 4 Tom "spot" Callaway 2005-08-23 11:34:34 EDT
All changes incorporated (both from patch and ?_smp_mflags) in -3.



Of course, we now depend on perl-Date-Simple, so this review depends on bugzilla
Comment 5 Paul Howarth 2005-08-23 13:14:11 EDT
Looks good.


Note You need to log in before you can comment on or make changes to this bug.