Bug 166195

Summary: Review Request: perl-Class-DBI-SQLite : Extension to Class::DBI for sqlite
Product: [Fedora] Fedora Reporter: Tom "spot" Callaway <tcallawa>
Component: Package ReviewAssignee: Paul Howarth <paul>
Status: CLOSED NEXTRELEASE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-package-review
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://search.cpan.org/dist/Class-DBI-SQLite/
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-09-04 22:18:55 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Bug Depends On: 166184    
Bug Blocks: 163779, 166188, 166203    
Attachments:
Description Flags
Patch addressing review issues none

Description Tom "spot" Callaway 2005-08-17 20:40:51 UTC
Spec Name or Url: 
http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-SQLite.spec

SRPM Name or Url:
http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-SQLite-0.09-2.src.rpm

Description: 

Extension to Class::DBI for sqlite

(NOTE: This package is one of the Maypole dependencies)

Comment 1 Paul Howarth 2005-09-01 16:05:25 UTC
Review:

- rpmlint clean
- package and spec file names OK
- package meets guidelines
- license is same as perl, matches spec
- spec file written in ENgish and is legible
- sources match upstream
- builds OK in mock on FC4 (i386)
- buildreqs mostly OK
- no locales, libraries, subpackages or pkgconfigs to worry about
- not relocatable
- no directory ownership or permissions issues
- no duplicate files
- %clean section present and correct
- macro usage is consistent
- code, not content
- no large docs
- docs don't affect runtime
- no scriptlets

Needswork:

- redundant BR: perl
- license text not included
- BR: perl(DBD::SQLite) needed

Nitpicks:

- there is now a version 0.10 at CPAN
- %{?_smp_mflags} could be used with make in %build


Comment 2 Paul Howarth 2005-09-01 16:06:58 UTC
Created attachment 118352 [details]
Patch addressing review issues

(obviously doesn't include update to 0.10...)

Comment 4 Paul Howarth 2005-09-02 08:53:34 UTC
Explicit "Requires: perl(Class::DBI)" is no longer needed; can be fixed in CVS.

Approved.


Comment 5 Paul Howarth 2005-09-02 09:40:00 UTC
I think that this is probably needed:

Requires: perl(DBD::SQLite)