Spec Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-SQLite.spec SRPM Name or Url: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-SQLite-0.09-2.src.rpm Description: Extension to Class::DBI for sqlite (NOTE: This package is one of the Maypole dependencies)
Review: - rpmlint clean - package and spec file names OK - package meets guidelines - license is same as perl, matches spec - spec file written in ENgish and is legible - sources match upstream - builds OK in mock on FC4 (i386) - buildreqs mostly OK - no locales, libraries, subpackages or pkgconfigs to worry about - not relocatable - no directory ownership or permissions issues - no duplicate files - %clean section present and correct - macro usage is consistent - code, not content - no large docs - docs don't affect runtime - no scriptlets Needswork: - redundant BR: perl - license text not included - BR: perl(DBD::SQLite) needed Nitpicks: - there is now a version 0.10 at CPAN - %{?_smp_mflags} could be used with make in %build
Created attachment 118352 [details] Patch addressing review issues (obviously doesn't include update to 0.10...)
0.10-1 has all the issues covered. SRPM: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-SQLite-0.10-1.src.rpm SPEC: http://www.auroralinux.org/people/spot/review/Maypole/perl-Class-DBI-SQLite.spec
Explicit "Requires: perl(Class::DBI)" is no longer needed; can be fixed in CVS. Approved.
I think that this is probably needed: Requires: perl(DBD::SQLite)