Bug 1662309 (python-ifaddr)

Summary: Review Request: python-ifaddr - Python library that allows you to find all the IP addresses of the computer
Product: [Fedora] Fedora Reporter: Igor Raits <igor.raits>
Component: Package ReviewAssignee: Neal Gompa <ngompa13>
Status: CLOSED CURRENTRELEASE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: ngompa13, package-review, ppisar
Target Milestone: ---Flags: ngompa13: fedora-review+
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-ifaddr-0.1.6-1.fc30 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2020-04-28 11:16:37 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Igor Raits 2018-12-27 15:36:21 UTC 
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-ifaddr.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-ifaddr-0.1.6-1.fc30.src.rpm
Description:
ifaddr is a small Python library that allows you to find all the IP addresses of the computer.
Fedora Account System Username: ignatenkobrain
Comment 1 Igor Raits 2018-12-27 15:37:49 UTC 
New Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-ifaddr.spec
New SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-ifaddr-0.1.6-1.fc30.src.rpm
Comment 2 Neal Gompa 2018-12-27 15:52:25 UTC 
Taking this review.
Comment 3 Neal Gompa 2018-12-27 15:55:40 UTC 
Review notes:

[x] Package is named properly according to Packaging Guidelines
[x] Package builds and installs properly
[x] Package follows Python packaging guidelines
[!] License file is missing
    * Pull request to include it in sdist submissions to PyPI has been submitted: https://github.com/pydron/ifaddr/pull/18
      - Please include the license as a second source from the upstream repo and install it properly before importing

PACKAGE APPROVED
Comment 4 Igor Raits 2018-12-27 16:00:45 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-ifaddr