Bug 1662309 (python-ifaddr) - Review Request: python-ifaddr - Python library that allows you to find all the IP addresses of the computer
Summary: Review Request: python-ifaddr - Python library that allows you to find all th...
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: python-ifaddr
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Neal Gompa
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-12-27 15:36 UTC by Igor Raits
Modified: 2020-04-28 11:16 UTC (History)
3 users (show)

Fixed In Version: python-ifaddr-0.1.6-1.fc30
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-04-28 11:16:37 UTC
Type: ---
ngompa13: fedora-review+


Attachments (Terms of Use)

Description Igor Raits 2018-12-27 15:36:21 UTC
Spec URL: https://ignatenkobrain.fedorapeople.org/for-review/python-ifaddr.spec
SRPM URL: https://ignatenkobrain.fedorapeople.org/for-review/python-ifaddr-0.1.6-1.fc30.src.rpm
Description:
ifaddr is a small Python library that allows you to find all the IP addresses of the computer.
Fedora Account System Username: ignatenkobrain

Comment 2 Neal Gompa 2018-12-27 15:52:25 UTC
Taking this review.

Comment 3 Neal Gompa 2018-12-27 15:55:40 UTC
Review notes:

[x] Package is named properly according to Packaging Guidelines
[x] Package builds and installs properly
[x] Package follows Python packaging guidelines
[!] License file is missing
    * Pull request to include it in sdist submissions to PyPI has been submitted: https://github.com/pydron/ifaddr/pull/18
      - Please include the license as a second source from the upstream repo and install it properly before importing

PACKAGE APPROVED

Comment 4 Igor Raits 2018-12-27 16:00:45 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-ifaddr


Note You need to log in before you can comment on or make changes to this bug.