Bug 166481
| Summary: | Review Request: ngrep - network grep | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Oliver Falk <oliver> |
| Component: | Package Review | Assignee: | Ville Skyttä <scop> |
| Status: | CLOSED ERRATA | QA Contact: | David Lawrence <dkl> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | byte, fedora-package-review, gilboad, jima, ondrejj, scop |
| Target Milestone: | --- | Flags: | j:
fedora-cvs+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| URL: | http://filelister.linux-kernel.at/mod_perl?current=/packages/FC_EXTRAS_APPROVAL/ngrep | ||
| Whiteboard: | |||
| Fixed In Version: | ngrep-1.45-8.1.el5 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2005-08-25 08:04:34 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 163779 | ||
|
Description
Oliver Falk
2005-08-22 11:09:32 UTC
https://www.redhat.com/archives/fedora-extras-list/2005-July/msg01009.html License is most certainly not GPL; in fact, to me it looks like it's GPL incompatible which means it cannot be used with the regexp stuff shipped in the tarball. I suggest you check out my package at the bottom of the message in the above URL and include the stuff in it (or similar) in your package. Also, the version of the software in the tarball is 1.44, not 1.44-1 or 1.44_1; that should be also in the package's Version tag. OK. Fixed. Please review again. More observations, fix for all of these can be merged from my old package:
Needswork:
- The executable needs to be run as root and the man page is in section 8, so
the executable would be better installed in %{_sbindir}, not %{_bindir}.
Cosmetics:
- Please use http://download.sourceforge.net/... (not prdownloads) so that
Source0 URL is wget'able.
- Group: Applications/Internet would be perhaps more appropriate than
Applications/System
Fixed. Please have a look again. Approved, but before importing, please change %{name}-%{version}.tar.bz2 in
the source URL to %{name}-%{version}-1.tar.bz2; the former contains an useless
~340kB bzip2'd static binary which just increases the SRPM size.
By the way, patching to use the system pcre was a good thing, see bug
166330 :)
Oh, I and just realized that I have no idea whether this works on < FC-4, the
bundled pcre is 5.0 and FC-3 has 4.5... so maybe push for >= FC-4 only?
OK, will change the source url and add the dist-tag. I will only build it for FE-4 and FE-devel... So FC-3 will not cause problems. :-) Thanks. Don't forget to add ngrep to owners.list in CVS... Yes, thanks, just did it. Normalize summary field for easy parsing Package Change Request ====================== Package Name: ngrep New Branches: el5 el6 Owners: jima oliver You can't just branch a package and make someone else the owner; we'll need an ack from jima. erm... i'm comaintainer. and i guess jima will not have any objection. however. i'll ask him to give a formal ok on this request. Consider it ACKed. I do appreciate the watchful eye, Jason. :-) I think you should set fedora-cvs flag to "?" again. Great. We've wasted time for bureaucracy where it wasn't needed... :-/ But OK, you just followed the rules. cvs-flag set. Well, I don't know what bureaucracy you're complaining about, but you are not listed as comaintainer on any branch in pkgdb and it would be rather rude to just make someone the owner of an additional branch without consulting them. Git done (by process-git-requests). ngrep-1.45-8.1.el5 has been submitted as an update for Fedora EPEL 5. https://admin.fedoraproject.org/updates/ngrep-1.45-8.1.el5 ngrep-1.45-7.el6 has been submitted as an update for Fedora EPEL 6. https://admin.fedoraproject.org/updates/ngrep-1.45-7.el6 ngrep-1.45-7.el6 has been pushed to the Fedora EPEL 6 stable repository. ngrep-1.45-8.1.el5 has been pushed to the Fedora EPEL 5 stable repository. |