Bug 1666294
| Summary: | Review Request: python-pylev - Liberally licensed, pure Python Levenshtein implementation | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Fabio Valentini <decathorpe> |
| Component: | Package Review | Assignee: | Neal Gompa <ngompa13> |
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | ngompa13, package-review, projects.rg |
| Target Milestone: | --- | Flags: | ngompa13:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-01-25 15:04:58 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1666306, 1666311, 1668387 | ||
|
Description
Fabio Valentini
2019-01-15 13:12:07 UTC
Taking this review. There's no license file installed for this. It looks like there is one in the upstream GitHub repo, but I guess it isn't present in the PyPI archive. Please fetch the license file from upstream and include it in the package. I've reported the missing LICENSE file upstream: https://github.com/toastdriven/pylev/issues/11 Fixed spec and SRPM available at the same links. Review notes: [x] Follows Fedora Packaging Guidelines [x] Follows Fedora Python Packaging Guidelines [x] Does not include Python 2 subpackage [x] Package is named per guidelines [x] Package builds and installs correctly [x] Package licensing is correct and documented correctly PACKAGE APPROVED. Thanks for the review! dist-git request: https://pagure.io/releng/fedora-scm-requests/issue/9519 (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pylev Built for rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1182128 My suggestion (lately) would be to just use "Pure Python Levenshtein implementation" as Summary. There's no need to repeat any license issues again because we've the License: and %license parts. (In reply to Raphael Groner from comment #8) > My suggestion (lately) would be to just use "Pure Python Levenshtein > implementation" as Summary. There's no need to repeat any license issues > again because we've the License: and %license parts. That's a good point. I'll adapt it when I submit the next build. |