Spec URL: https://decathorpe.fedorapeople.org/packages/python-pylev.spec SRPM URL: https://decathorpe.fedorapeople.org/packages/python-pylev-1.3.0-1.fc29.src.rpm Description: A pure Python Levenshtein implementation that’s not freaking GPL’d. Based off the Wikipedia code samples at https://en.wikipedia.org/wiki/Levenshtein_distance. Fedora Account System Username: decathorpe koji scratch build for rawhide: https://koji.fedoraproject.org/koji/taskinfo?taskID=32043369
Taking this review.
There's no license file installed for this. It looks like there is one in the upstream GitHub repo, but I guess it isn't present in the PyPI archive. Please fetch the license file from upstream and include it in the package.
I've reported the missing LICENSE file upstream: https://github.com/toastdriven/pylev/issues/11 Fixed spec and SRPM available at the same links.
Review notes: [x] Follows Fedora Packaging Guidelines [x] Follows Fedora Python Packaging Guidelines [x] Does not include Python 2 subpackage [x] Package is named per guidelines [x] Package builds and installs correctly [x] Package licensing is correct and documented correctly PACKAGE APPROVED.
Thanks for the review! dist-git request: https://pagure.io/releng/fedora-scm-requests/issue/9519
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pylev
Built for rawhide: https://koji.fedoraproject.org/koji/buildinfo?buildID=1182128
My suggestion (lately) would be to just use "Pure Python Levenshtein implementation" as Summary. There's no need to repeat any license issues again because we've the License: and %license parts.
(In reply to Raphael Groner from comment #8) > My suggestion (lately) would be to just use "Pure Python Levenshtein > implementation" as Summary. There's no need to repeat any license issues > again because we've the License: and %license parts. That's a good point. I'll adapt it when I submit the next build.