Bug 1669875

Summary:	Icon in /usr/share/pixmaps/PACKAGE.png not detected
Product:	[Community] rpmgrill	Reporter:	Sylvain Beucler <beuc>
Component:	Tests	Assignee:	beaker-dev-list
Status:	CLOSED DUPLICATE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	0.23	CC:	cfreitas, jorris, ppisar, rpotts
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-03-25 09:30:49 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Sylvain Beucler 2019-01-27 15:30:01 UTC

Description of problem:
I see at
https://taskotron.fedoraproject.org/artifacts/all/e40b4a1e-1b7e-11e9-9451-525400fc9f92/tests.yml/rpmgrill.json
that the icon installed at
/usr/share/pixmaps/freedink.png
is not detected.

Version-Release number of selected component (if applicable):
(the one at taskotron)

How reproducible:
Always

Steps to Reproduce:
1. The .desktop file mentions Icon=xxx
2. Install icon at /usr/share/pixmaps/xxx.png

Actual results:
Icon file <var>xxx</var> not found"

Expected results:
OK

Additional info:

I see that DesktopLint.pm contains:
        $icon_re = qr{^/usr/share/(icons|pixmaps)/.*\Q/$icon\E\.(png|xpm|svg)$};
which means it enforces a sub-directory (/$icon instead of $icon).
/usr/share/pixmaps is flat (unlike /usr/share/icons) so this is too strict.

Comment 1 Petr Pisar 2019-03-25 09:30:49 UTC


*** This bug has been marked as a duplicate of bug 1539633 ***