Bug 1539633 - DesktopLint does not search icons directly in /usr/share/pixmaps
Summary: DesktopLint does not search icons directly in /usr/share/pixmaps
Keywords:
Status: MODIFIED
Alias: None
Product: rpmgrill
Classification: Community
Component: Infrastructure
Version: 0.31
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
: ---
Assignee: beaker-dev-list
QA Contact:
URL:
Whiteboard:
: 1669875 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2018-01-29 11:10 UTC by Petr Pisar
Modified: 2019-04-27 23:10 UTC (History)
3 users (show)

Fixed In Version: rpmgrill-0.34-1.fc31
Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github default-to-open rpmgrill pull 27 0 None None None 2019-03-25 11:32:48 UTC

Description Petr Pisar 2018-01-29 11:10:55 UTC
rpmgrill reports a false error in gscan2pdf-1.8.11-1.fc28 <https://taskotron.fedoraproject.org/artifacts/all/72ccc840-04e2-11e8-81b5-525400fc9f92/task_output/rpmgrill.json>:

      {
         "module" : "DesktopLint",
         "order" : 93,
         "results" : [
            {
               "arch" : "noarch",
               "code" : "DesktopIconFileMissing",
               "context" : {
                  "excerpt" : [
                     "Icon=gscan2pdf"
                  ],
                  "lineno" : 7,
                  "path" : "/usr/share/applications/gscan2pdf.desktop"
               },
               "diag" : "Icon file <var>gscan2pdf</var> not found",
               "subpackage" : "gscan2pdf"
            }
         ],

The packages installs "gscan2pdf" icon into /usr/share/pixmaps/gscan2pdf.svg, yet the DesktopLint module does not recognize it.

The patch is valid one per <https://specifications.freedesktop.org/desktop-entry-spec/desktop-entry-spec-1.1.html#key-icon> and <https://specifications.freedesktop.org/icon-theme-spec/icon-theme-spec-latest.html#directory_layout>.

Comment 1 Matt Prahl 2018-04-02 14:16:17 UTC
I ran into this problem as well.

Comment 2 Petr Pisar 2019-03-25 09:30:49 UTC
*** Bug 1669875 has been marked as a duplicate of this bug. ***

Comment 3 Petr Pisar 2019-03-25 11:32:49 UTC
A fix is available at <https://github.com/default-to-open/rpmgrill/pull/27>.

Comment 4 Fedora Update System 2019-04-27 23:10:33 UTC
rpmgrill-0.34-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.