Bug 1670327

Created attachment 1524522 [details]
After Upgrade i.e. CFME 5.9.6

Drew, can you take look at this one?  Please let me know if you need more clarification on the existing bug mentioned in comment #6

The appliance for the global shows the file in the UI that's got the view code for this as missing https://github.com/ManageIQ/manageiq-ui-classic/pull/5126.  5126 was merged after that appliance was built. Can you please retest on the latest for this version?

Per comment #8, please retest on 5.9.8

Does the same issue apply on new 5.9.6 deployments or only upgraded?

Hello,

Give me some to check

1. Retest on 5.9.8.
2. If it applies on new 5.9.6 deployments or only upgraded?

I will update you soon.

Cool, thanks for checking for me. May I have access to the appliance you did the upgrade on, please?

Both of those are missing the code I talked about in comment 8. I wouldn't expect this to work without that code.

This is also entirely a UI issue.

Dennis, can you tell me why https://github.com/ManageIQ/manageiq-ui-classic/pull/5126 isn't showing up on those appliances even though it was backported to that version and was before the appliance creation date? This is completely an issue that's out of my scope to be able to fix...

Sorry Dennis, cancelling the needinfo on you. 

Khushbu, those appliances are the wrong version number. They're not 5.9.8. 
This is fixed on 5.9.8. I'd like to motion to close this ticket as works on current release.

Khushbu, can I please close this?

Hi Drew,

the update to 5.9.8 did not solve the issue for the customer.
I have uploaded dialog screenshot they have shared just after their update.

Please let me know what more information you need from customer environment

Created attachment 1535056 [details]
dialog empty

Hey Niladri, any chance you might be able to give me a reproducer that's on the correct version please?

Why did you say this was verified if it's not working?

We're running https://github.com/ManageIQ/manageiq-ui-classic/blob/gaprindashvili/app/views/miq_request/_request_dialog_details.html.haml#L10, but the field_value isn't correct there which is odd.

https://github.com/ManageIQ/manageiq/pull/18469

How to implement it to Cloudforms 5.9.8.1 latest version?
Thank you

New commit detected on ManageIQ/manageiq/master:

https://github.com/ManageIQ/manageiq/commit/142c1588ab7b5bab917aeca2b823e8b0fc205d08
commit 142c1588ab7b5bab917aeca2b823e8b0fc205d08
Author:     Erik Clarizio <eclarizi>
AuthorDate: Wed Feb 20 11:42:34 2019 -0500
Commit:     Erik Clarizio <eclarizi>
CommitDate: Wed Feb 20 11:42:34 2019 -0500

    Use indifferent_access for assigning request values to dialog fields

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1670327

 app/models/dialog.rb | 2 +
 spec/models/dialog_spec.rb | 40 +-
 2 files changed, 32 insertions(+), 10 deletions(-)

Hi Khushbu,

I understand that this is a priority for the customer and am looking into the issue.

I'll let you know as soon as I have more information.

Thanks,
Tina

Hi Khushbu,

We have a code change that I believe will resolve the customer issue, but I want to test it more before we ask for a hot fix.

Can you setup a 5.9.9 reproducer environment?

Thank you for all of your work on this issue.

Regards,
Tina

Hi Khushbu,

I'm sorry, I didn't realize that 5.9.9 was not available.

Could you setup the reproducer environment with the latest 5.8 build then?

Thanks,
Tina

Created attachment 1586664 [details]
working catalog display

It works

Version 5.11.0.11.20190625161125_392c61e