Bug 1670327 - Unable to see dialog details passed to catalog after upgrade from 5.9.4 to 5.9.6
Summary: Unable to see dialog details passed to catalog after upgrade from 5.9.4 to 5.9.6
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: Automate
Version: 5.9.6
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: GA
: 5.11.0
Assignee: eclarizi
QA Contact: Jaroslav Henner
Red Hat CloudForms Documentation
URL:
Whiteboard:
Depends On:
Blocks: 1688870 1688871
TreeView+ depends on / blocked
 
Reported: 2019-01-29 09:48 UTC by Khushbu Borole
Modified: 2019-12-17 12:35 UTC (History)
17 users (show)

Fixed In Version: 5.11.0.1
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1688870 1688871 (view as bug list)
Environment:
Last Closed: 2019-12-13 15:08:35 UTC
Category: Bug
Cloudforms Team: CFME Core
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)
Before Upgarde i.e. CFME 5.9.4 (38.50 KB, image/png)
2019-01-29 09:48 UTC, Khushbu Borole
no flags Details
After Upgrade i.e. CFME 5.9.6 (33.43 KB, image/png)
2019-01-29 09:49 UTC, Khushbu Borole
no flags Details
dialog empty (13.33 KB, image/png)
2019-02-15 07:42 UTC, Niladri Roy
no flags Details
working catalog display (46.54 KB, image/png)
2019-07-02 11:13 UTC, Jaroslav Henner
no flags Details

Description Khushbu Borole 2019-01-29 09:48:33 UTC
Created attachment 1524521 [details]
Before Upgarde i.e. CFME 5.9.4

Description of problem:
Unable to see dialog details passed to catalog while ordering the service from global region after the upgrade of 5.9.4 to 5.9.6 [Multi Region Setup]

How reproducible:
Every time when we order a catalog with dialog after the upgrade from 5.9.4 to 5.9.6 from a Global Region

Steps to Reproduce:
1. Setup a Multi Region environment of CFME version 5.9.4
2. Add repository and create a service catalog with a dialog at remote region
3. Try provisioning the catalog from Global Region
[ You can see the dialog details in Services -> Requests page ]
4. Upgrade the setup from 5.9.4 to 5.9.6
5. Try provisioning the catalog from Global Region
[ You can not see the dialog details in Services -> Requests page ]

Refer the attached images before upgrade and after upgrade.

Actual results:
The dialog details at Services -> Requests are not displayed after upgrade to 5.9.6 when ordering the catalog from the Global Region

Expected results:
The dialog details at Services -> Requests should be displayed after upgrade to 5.9.6 when ordering the catalog from the Global Region

Comment 2 Khushbu Borole 2019-01-29 09:49:16 UTC
Created attachment 1524522 [details]
After Upgrade i.e. CFME 5.9.6

Comment 7 Joe Rafaniello 2019-01-30 15:49:54 UTC
Drew, can you take look at this one?  Please let me know if you need more clarification on the existing bug mentioned in comment #6

Comment 8 drew uhlmann 2019-01-30 16:59:03 UTC
The appliance for the global shows the file in the UI that's got the view code for this as missing https://github.com/ManageIQ/manageiq-ui-classic/pull/5126.  5126 was merged after that appliance was built. Can you please retest on the latest for this version?

Comment 9 dmetzger 2019-01-31 14:06:10 UTC
Per comment #8, please retest on 5.9.8

Comment 10 dmetzger 2019-01-31 19:01:17 UTC
Does the same issue apply on new 5.9.6 deployments or only upgraded?

Comment 11 Khushbu Borole 2019-02-01 11:11:52 UTC
Hello,

Give me some to check

1. Retest on 5.9.8.
2. If it applies on new 5.9.6 deployments or only upgraded?

I will update you soon.

Comment 13 drew uhlmann 2019-02-04 13:00:46 UTC
Cool, thanks for checking for me. May I have access to the appliance you did the upgrade on, please?

Comment 15 drew uhlmann 2019-02-04 13:14:57 UTC
Both of those are missing the code I talked about in comment 8. I wouldn't expect this to work without that code.

Comment 16 drew uhlmann 2019-02-04 13:17:50 UTC
This is also entirely a UI issue.

Comment 17 drew uhlmann 2019-02-04 13:25:10 UTC
Dennis, can you tell me why https://github.com/ManageIQ/manageiq-ui-classic/pull/5126 isn't showing up on those appliances even though it was backported to that version and was before the appliance creation date? This is completely an issue that's out of my scope to be able to fix...

Comment 18 drew uhlmann 2019-02-04 21:25:56 UTC
Sorry Dennis, cancelling the needinfo on you. 

Khushbu, those appliances are the wrong version number. They're not 5.9.8. 
This is fixed on 5.9.8. I'd like to motion to close this ticket as works on current release.

Comment 19 drew uhlmann 2019-02-05 13:52:46 UTC
Khushbu, can I please close this?

Comment 21 Niladri Roy 2019-02-15 07:41:04 UTC
Hi Drew,

the update to 5.9.8 did not solve the issue for the customer.
I have uploaded dialog screenshot they have shared just after their update.

Please let me know what more information you need from customer environment

Comment 22 Niladri Roy 2019-02-15 07:42:42 UTC
Created attachment 1535056 [details]
dialog empty

Comment 23 drew uhlmann 2019-02-15 14:10:58 UTC
Hey Niladri, any chance you might be able to give me a reproducer that's on the correct version please?

Comment 26 drew uhlmann 2019-02-20 13:01:09 UTC
Why did you say this was verified if it's not working?

Comment 28 drew uhlmann 2019-02-20 13:34:50 UTC
We're running https://github.com/ManageIQ/manageiq-ui-classic/blob/gaprindashvili/app/views/miq_request/_request_dialog_details.html.haml#L10, but the field_value isn't correct there which is odd.

Comment 30 Jan Hladik 2019-03-07 13:45:03 UTC
How to implement it to Cloudforms 5.9.8.1 latest version?
Thank you

Comment 32 CFME Bot 2019-03-08 16:51:14 UTC
New commit detected on ManageIQ/manageiq/master:

https://github.com/ManageIQ/manageiq/commit/142c1588ab7b5bab917aeca2b823e8b0fc205d08
commit 142c1588ab7b5bab917aeca2b823e8b0fc205d08
Author:     Erik Clarizio <eclarizi>
AuthorDate: Wed Feb 20 11:42:34 2019 -0500
Commit:     Erik Clarizio <eclarizi>
CommitDate: Wed Feb 20 11:42:34 2019 -0500

    Use indifferent_access for assigning request values to dialog fields

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1670327

 app/models/dialog.rb | 2 +
 spec/models/dialog_spec.rb | 40 +-
 2 files changed, 32 insertions(+), 10 deletions(-)

Comment 33 Tina Fitzgerald 2019-03-08 19:24:09 UTC
Hi Khushbu,

I understand that this is a priority for the customer and am looking into the issue.

I'll let you know as soon as I have more information.

Thanks,
Tina

Comment 34 Tina Fitzgerald 2019-03-08 20:56:54 UTC
Hi Khushbu,

We have a code change that I believe will resolve the customer issue, but I want to test it more before we ask for a hot fix.

Can you setup a 5.9.9 reproducer environment?

Thank you for all of your work on this issue.

Regards,
Tina

Comment 36 Tina Fitzgerald 2019-03-12 13:49:51 UTC
Hi Khushbu,

I'm sorry, I didn't realize that 5.9.9 was not available.

Could you setup the reproducer environment with the latest 5.8 build then?

Thanks,
Tina

Comment 47 Jaroslav Henner 2019-07-02 11:13:57 UTC
Created attachment 1586664 [details]
working catalog display

It works

Comment 48 Jaroslav Henner 2019-07-02 11:15:23 UTC
Version 5.11.0.11.20190625161125_392c61e


Note You need to log in before you can comment on or make changes to this bug.