Bug 1671728

Summary:	Review Request: perl-HTTP-CookieMonster - Easy access to your jar of HTTP::Cookies
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Jitka Plesnikova <jplesnik>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jplesnik, package-review
Target Milestone:	---	Flags:	jplesnik: fedora-review+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-HTTP-CookieMonster-0.09-1.fc30	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-02-05 15:53:10 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Petr Pisar 2019-02-01 13:17:55 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-HTTP-CookieMonster/perl-HTTP-CookieMonster.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-HTTP-CookieMonster/perl-HTTP-CookieMonster-0.09-1.fc30.src.rpm
Description:
HTTP::CookieMonster gives you a simple interface for getting and setting
cookies in HTTP::Cookies objects.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2019-02-05 15:19:33 UTC

Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are ok
TODO: perl(English) is not used, because author tests are disabled.

$ rpm -qp --requires perl-HTTP-CookieMonster-0.09-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(Carp)
      1 perl(HTTP::CookieMonster::Cookie)
      1 perl(HTTP::Cookies)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(Moo) >= 1.000003 
      1 perl(Safe::Isa)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Sub::Exporter)
      1 perl(URI::Escape)
      1 perl(:VERSION) >= 5.6.0
      1 perl(warnings) 
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-HTTP-CookieMonster-0.09-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(HTTP::CookieMonster) = 0.09
      1 perl-HTTP-CookieMonster = 0.09-1.fc30
      1 perl(HTTP::CookieMonster::Cookie) = 0.09 
Binary provides are Ok.

$ rpmlint ./perl-HTTP-CookieMonster*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2019-02-05 15:32:04 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-HTTP-CookieMonster

Comment 3 Petr Pisar 2019-02-05 15:53:10 UTC

Thank you for the review and the repository.

Comment 4 Petr Pisar 2019-02-05 15:53:34 UTC

I removed the useless dependency.