Bug 1671728 - Review Request: perl-HTTP-CookieMonster - Easy access to your jar of HTTP::Cookies
Summary: Review Request: perl-HTTP-CookieMonster - Easy access to your jar of HTTP::Co...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-02-01 13:17 UTC by Petr Pisar
Modified: 2019-02-05 15:53 UTC (History)
2 users (show)

Fixed In Version: perl-HTTP-CookieMonster-0.09-1.fc30
Clone Of:
Environment:
Last Closed: 2019-02-05 15:53:10 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2019-02-01 13:17:55 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-HTTP-CookieMonster/perl-HTTP-CookieMonster.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-HTTP-CookieMonster/perl-HTTP-CookieMonster-0.09-1.fc30.src.rpm
Description:
HTTP::CookieMonster gives you a simple interface for getting and setting
cookies in HTTP::Cookies objects.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2019-02-05 15:19:33 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed

BuildRequires are ok
TODO: perl(English) is not used, because author tests are disabled.

$ rpm -qp --requires perl-HTTP-CookieMonster-0.09-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(Carp)
      1 perl(HTTP::CookieMonster::Cookie)
      1 perl(HTTP::Cookies)
      1 perl(:MODULE_COMPAT_5.28.1)
      1 perl(Moo) >= 1.000003 
      1 perl(Safe::Isa)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(Sub::Exporter)
      1 perl(URI::Escape)
      1 perl(:VERSION) >= 5.6.0
      1 perl(warnings) 
      1 rpmlib(CompressedFileNames) <= 3.0.4-1
      1 rpmlib(FileDigests) <= 4.6.0-1
      1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
      1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.

$ rpm -qp --provides perl-HTTP-CookieMonster-0.09-1.fc30.noarch.rpm | sort | uniq -c
      1 perl(HTTP::CookieMonster) = 0.09
      1 perl-HTTP-CookieMonster = 0.09-1.fc30
      1 perl(HTTP::CookieMonster::Cookie) = 0.09 
Binary provides are Ok.

$ rpmlint ./perl-HTTP-CookieMonster*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.

The package looks good.
Approved

Comment 2 Gwyn Ciesla 2019-02-05 15:32:04 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-HTTP-CookieMonster

Comment 3 Petr Pisar 2019-02-05 15:53:10 UTC
Thank you for the review and the repository.

Comment 4 Petr Pisar 2019-02-05 15:53:34 UTC
I removed the useless dependency.


Note You need to log in before you can comment on or make changes to this bug.