Bug 167673
Summary: | Review Request: flow-tools - Tool set for working with NetFlow data | ||||||
---|---|---|---|---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Paul P Komkoff Jr <i> | ||||
Component: | Package Review | Assignee: | Tom "spot" Callaway <tcallawa> | ||||
Status: | CLOSED NEXTRELEASE | QA Contact: | David Lawrence <dkl> | ||||
Severity: | medium | Docs Contact: | |||||
Priority: | medium | ||||||
Version: | rawhide | CC: | fedora-extras-list, orion | ||||
Target Milestone: | --- | Flags: | gwync:
fedora-cvs+
|
||||
Target Release: | --- | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
URL: | http://www.splintered.net/sw/flow-tools/ | ||||||
Whiteboard: | |||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||
Doc Text: | Story Points: | --- | |||||
Clone Of: | Environment: | ||||||
Last Closed: | 2005-09-08 08:24:47 UTC | Type: | --- | ||||
Regression: | --- | Mount Type: | --- | ||||
Documentation: | --- | CRM: | |||||
Verified Versions: | Category: | --- | |||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
Cloudforms Team: | --- | Target Upstream Version: | |||||
Embargoed: | |||||||
Bug Depends On: | |||||||
Bug Blocks: | 163779 | ||||||
Attachments: |
|
Description
Paul P Komkoff Jr
2005-09-06 20:40:59 UTC
Created attachment 118537 [details]
pre-review fixes
There were several items I noticed in the course of the review. Specifically:
- some missing macros
- %{version} not being used in Source
- Group should be Application/System, not System Environment/Daemons
- didn't own/create %{_localstatedir}/ft/
- missing BR: autoconf
- don't need generic INSTALL
- config files not marked config(noreplace)
- don't own all directories we create
- wasn't running ldconfig on post/postun
I've attached a patch which covers these issues. Please apply this patch, and
I'll review the package.
Apllied. Now: Spec Name or Url: http://mirrors.sgu.ru/mm/s/SPECS/flow-tools.spec SRPM Name or Url: http://mirrors.sgu.ru/mm/s/4/SRPMS/flow-tools-0.68-2.src.rpm Review: Good: - rpmlint checks return: W: flow-tools-devel no-documentation Safe to ignore. - meets Packaging, naming guidelines - license (BSD) OK, text in %doc, matches source - spec in am. english, legible - source matches upstream - compiles on x86 devel - no missing, unnecessary BuildRequires - no locales - post/postun ldconfig ok - not relocatable - owns all dirs it creates - no duplicate files - permissions ok - clean ok - macros consistent - code, not content - no need for -docs - -devel ok - -devel requires main package n-v-r - not a gui app - .la files removed Nitpick: - the url for Patch0 (http://stingr.net/2/flow-tools/flow-tools-0.68a.patch) is a 404. You should either fix the URL or drop it entirely (its not needed). APPROVED. Package Change Request ====================== Package Name: flow-tools New Branches: EL-4 EL-5 EL-6 Owners: stingray orion CVS done (by process-cvs-requests.py). Package Change Request ====================== Package Name: flow-tools New Branches: epel7 Owners: stingray orion Git done (by process-git-requests). |