Spec Name or Url: http://mirrors.sgu.ru/mm/s/SPECS/flow-tools.spec SRPM Name or Url: http://mirrors.sgu.ru/mm/s/4/SRPMS/flow-tools-0.68-1.src.rpm Description: Flow-tools is library and a collection of programs used to collect, send, process, and generate reports from NetFlow data. The tools can be used together on a single server or distributed to multiple servers for large deployments. The flow-toools library provides an API for development of custom applications for NetFlow export versions 1,5,6 and the 14 currently defined version 8 subversions. A Perl and Python interface have been contributed and are included in the distribution.
Created attachment 118537 [details] pre-review fixes There were several items I noticed in the course of the review. Specifically: - some missing macros - %{version} not being used in Source - Group should be Application/System, not System Environment/Daemons - didn't own/create %{_localstatedir}/ft/ - missing BR: autoconf - don't need generic INSTALL - config files not marked config(noreplace) - don't own all directories we create - wasn't running ldconfig on post/postun I've attached a patch which covers these issues. Please apply this patch, and I'll review the package.
Apllied. Now: Spec Name or Url: http://mirrors.sgu.ru/mm/s/SPECS/flow-tools.spec SRPM Name or Url: http://mirrors.sgu.ru/mm/s/4/SRPMS/flow-tools-0.68-2.src.rpm
Review: Good: - rpmlint checks return: W: flow-tools-devel no-documentation Safe to ignore. - meets Packaging, naming guidelines - license (BSD) OK, text in %doc, matches source - spec in am. english, legible - source matches upstream - compiles on x86 devel - no missing, unnecessary BuildRequires - no locales - post/postun ldconfig ok - not relocatable - owns all dirs it creates - no duplicate files - permissions ok - clean ok - macros consistent - code, not content - no need for -docs - -devel ok - -devel requires main package n-v-r - not a gui app - .la files removed Nitpick: - the url for Patch0 (http://stingr.net/2/flow-tools/flow-tools-0.68a.patch) is a 404. You should either fix the URL or drop it entirely (its not needed). APPROVED.
Package Change Request ====================== Package Name: flow-tools New Branches: EL-4 EL-5 EL-6 Owners: stingray orion
CVS done (by process-cvs-requests.py).
Package Change Request ====================== Package Name: flow-tools New Branches: epel7 Owners: stingray orion
Git done (by process-git-requests).