Bug 167889

Summary:	Review Request: polyxmass-data - Contains configuration files describing polymer chemistry
Product:	[Fedora] Fedora	Reporter:	Andreas Bierfert <andreas.bierfert>
Component:	Package Review	Assignee:	John Mahowald <jpmahowald>
Status:	CLOSED NEXTRELEASE	QA Contact:	David Lawrence <dkl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	fedora-extras-list
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
URL:	http://www.polyxmass.org
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-10-26 06:36:21 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	167887
Bug Blocks:	163779

Description Andreas Bierfert 2005-09-09 07:56:28 UTC

Spec Name or Url: http://fedora.lowlatency.de/review/polyxmass-data.spec
SRPM Name or Url: http://fedora.lowlatency.de/review/polyxmass-data-0.8.6-1.src.rpm
Description: 
polyxmass-data is a platform-independent package that contains all
textual/graphical data required to run the GNU polyxmass software out of
the box.  Namely, GNU polyxmassdata contains configuration files describing
polymer chemistry for a number of polymer types commonly found in nature:
protein, dna, rna, saccharides. These polymer chemistry definitions are
examples, and should be carefully reviewed by the user of the GNU polyxmass
software, in order to make sure that they fulfill their task in the
best way.

Comment 1 John Mahowald 2005-10-22 22:58:37 UTC

This data is necessary for polyxmass to be useful, so it is acceptable data

- package meets naming guidelines
- package meets packaging guidelines
- license (GPL) OK, text in %doc
- spec file legible
- source matches upstream
- package compiles on FC4 i386
- no BR
- no locales
- not relocatable
- no duplicate files
- permissions ok
- %clean ok
- macro use consistent
- code, not content
- no need for -docs
- nothing in %doc affects runtime
- no need for .desktop file 

needs work:
- does not appear to own or require /usr/share/polyxmass
- rpmlint:
W: polyxmass-data non-conffile-in-etc
/etc/polyxmass/polchem-defs/polyxmass-data-polchem-defs-cat
W: polyxmass-data non-conffile-in-etc
/etc/polyxmass/polchem-defs/polyxmass-data-polchem-defs-atom-defs-dic

and a while lot of zero length .ogg files. Are the oggs necessary? The conffile
can probably be ignored, it's really a config file.

Comment 2 Andreas Bierfert 2005-10-22 23:21:08 UTC

Hm I don't know about the .ogg files but /usr/share/polyxmass is owned by
polyxmass-bin and thus ok because polyxmass-data requires polyxmass-bin... =)

Comment 3 John Mahowald 2005-10-23 03:09:31 UTC

OK, polyxmass-bin owns /usr/share/polyxmass. And the zero length isn't a big deal.

APPROVED

Now waiting on polyxmass-bin.

Comment 4 Paul Howarth 2005-10-23 13:13:32 UTC

(In reply to comment #1)
> This data is necessary for polyxmass to be useful, so it is acceptable data
> 
> - package meets naming guidelines
> - package meets packaging guidelines
> - license (GPL) OK, text in %doc
> - spec file legible
> - source matches upstream
> - package compiles on FC4 i386
> - no BR
> - no locales
> - not relocatable
> - no duplicate files
> - permissions ok
> - %clean ok
> - macro use consistent
> - code, not content
> - no need for -docs
> - nothing in %doc affects runtime
> - no need for .desktop file 
> 
> needs work:
> - does not appear to own or require /usr/share/polyxmass
> - rpmlint:
> W: polyxmass-data non-conffile-in-etc
> /etc/polyxmass/polchem-defs/polyxmass-data-polchem-defs-cat
> W: polyxmass-data non-conffile-in-etc
> /etc/polyxmass/polchem-defs/polyxmass-data-polchem-defs-atom-defs-dic
> 
> and a while lot of zero length .ogg files. Are the oggs necessary? The conffile
> can probably be ignored, it's really a config file.

If the files in /etc/polyxmass really are config files, perhaps then they should
be marked as such?

%config %{_sysconfdir}/polyxmass/polchem-defs*
or
%config(noreplace) %{_sysconfdir}/polyxmass/polchem-defs/*

Comment 5 Andreas Bierfert 2005-10-24 08:57:33 UTC

I have been thinking about this for some time and while these are definitions
used by the program I don't think they are config files in the rpm sense that
comes to mind when thinking about %config.

Comment 6 Paul Howarth 2005-10-24 09:32:55 UTC

(In reply to comment #5)
> I have been thinking about this for some time and while these are definitions
> used by the program I don't think they are config files in the rpm sense that
> comes to mind when thinking about %config.

Perhaps a better location for them would be %{_datadir}/polyxmass rather than
%{_sysconfdir}/polyxmass then? Is that feasible?

Comment 7 Andreas Bierfert 2005-10-26 06:36:21 UTC

Hm... I guess leaving them and marking them as %config is the best way to go
after all if this is ok with you...

Build for fc{3,4,5}

Thanks for the review :)