Red Hat Bugzilla – Bug 167887
Review Request: polyxmass-bin - The GNU polyxmass software suite
Last modified: 2007-11-30 17:11:13 EST
Spec Name or Url: http://fedora.lowlatency.de/review/polyxmass-bin.spec
SRPM Name or Url: http://fedora.lowlatency.de/review/polyxmass-bin-0.8.9-1.src.rpm
polyxdef is the GNU polyxmass software project's module where the
user makes/modifies polymer chemistry definitions. Those polymer
chemistry definitions are then saved to a disk file under an xml-based
format that will be understandable by other modules in the GNU
polyxmass software suite.
polyxcalc is the GNU polyxmass software project's module where the
user makes simple mass calculations on a number of chemically-relevant
polyxedit is the GNU polyxmass software project's module where the
user performs tasks on a polymer sequence.
* name OK, matches upstream (though I would probably have just called it polyxmass)
* license good (GPL), in %doc
* specfile legible
* builds on FC4 i386
* uses %find_lang
* owns its directories
* consistent macro use
* %clean OK
* %docs good, no need for seperate package
* app runs
* .desktop file, installed with desktop-file-install
* minor: rpmlint only can't find changelog version:
W: polyxmass-bin no-version-in-last-changelog
W: polyxmass-bin-debuginfo no-version-in-last-changelog
the purpose of the patch is to make it compile without -Werror?
yes thats what the patch is for because optflags make the build noisy...
desktop icon has been added =)
The desktop file was added, but it really needs an icon. I suggest
This line to the desktop file should do it:
Here you go :)
Looks good with the icon.
checked in and build... could you please change to FE-ACCEPT?