Bug 1679946

Summary:	[Multus][network-operator] Should be able to configure the namespace of the default net-attach-def
Product:	OpenShift Container Platform	Reporter:	Meng Bo <bmeng>
Component:	Networking	Assignee:	Casey Callendrello <cdc>
Networking sub component:	openshift-sdn	QA Contact:	zhaozhanqi <zzhao>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	low
Priority:	medium	CC:	aos-bugs, bbennett, cdc, dcbw, dosmith, sponnaga, tohayash, zshi
Version:	4.1.0	Keywords:	NeedsTestCase
Target Milestone:	---
Target Release:	4.1.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-06-04 10:44:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Meng Bo 2019-02-22 10:15:58 UTC

Description of problem:
Currently, if we define the net-attach-def in additionalNetwork during installation. It will create the cr in the "default" namespace by hardcoded. And the namespaceIsolation is enabled by default. That means the cr defined in additionalNetwork is hardly be used.

We should put the net-attach-def in the multusNamespace which introduced in https://github.com/intel/multus-cni/pull/254


Version-Release number of selected component (if applicable):
v4.0.0-0.177.0

How reproducible:
always

Steps to Reproduce:
1. Setup OCP cluster with the following networkconfig.networkoperator.openshift.io

apiVersion: networkoperator.openshift.io/v1
kind: NetworkConfig
metadata:
  name: default
spec:
  additionalNetworks:
  - name: macvlan-conf
    rawCNIConfig: '{ "type": "macvlan", "name": "macvlan-network", "master": "eth0",
      "ipam": { "type": "host-local", "subnet": "10.200.1.0/24", "routes": [{ "dst":
      "0.0.0.0/0" }], "gateway": "10.200.1.1" } }'
    type: Raw
  clusterNetworks:
  - cidr: 10.128.0.0/14
    hostSubnetLength: 9
  defaultNetwork:
    openshiftSDNConfig:
      mode: NetworkPolicy
    type: OpenShiftSDN
  serviceNetwork: 172.30.0.0/16

2. Check the net-attach-def created after the cluster setup
3.

Actual results:
The net-attach-def is created under default namespace and hardly be used. Means the additionalNetwork is kind of useless.

Expected results:
Should be able to modify the namespace value or put it under multusNamespace which introduced in https://github.com/intel/multus-cni/pull/254

Additional info:

Comment 1 Casey Callendrello 2019-02-22 12:50:22 UTC

Dan,
Can you take a look at this?

Comment 2 Tomofumi Hayashi 2019-02-22 12:58:36 UTC

Dan,

I've submit fix PR for that into upstream: https://github.com/intel/multus-cni/pull/271

Comment 3 Tomofumi Hayashi 2019-02-22 12:59:18 UTC

Casay,

Can I take it?
If you don't mind, I assign it to me.

Comment 4 Tomofumi Hayashi 2019-02-22 13:51:21 UTC

Casey and Dan,

Let me clarify the above PR.
From multus side, we have issue around clusterNetwork, https://github.com/intel/multus-cni/issues/261
Multus will choose different namesppace for clusterNetwork (it should be multusNamespace, but actually it reads from default).
Above PR is to fix this issue.

Comment 5 zenghui.shi 2019-02-25 02:10:01 UTC

(In reply to Tomofumi Hayashi from comment #4)
> Casey and Dan,
> 
> Let me clarify the above PR.
> From multus side, we have issue around clusterNetwork,
> https://github.com/intel/multus-cni/issues/261
> Multus will choose different namesppace for clusterNetwork (it should be
> multusNamespace, but actually it reads from default).
> Above PR is to fix this issue.

I think there are two folders of this problem:
1) Even multus supports 'systemNamespaces' and 'multusNamespace', it's not configurable via operator.
2) In operator, the namespace in net-attach-def custom resource template is hardcoded to 'default' namespace.

Comment 7 Ben Bennett 2019-04-02 12:58:08 UTC

@Tomofumi I see the multus-cni plugin has merged.  Do we need to do anything to bring that code in to OpenShift 4.1?

Comment 8 Dan Williams 2019-04-23 16:19:43 UTC

https://github.com/openshift/api/pull/294
https://github.com/openshift/cluster-network-operator/pull/152

Comment 10 Meng Bo 2019-05-08 12:20:02 UTC

Tested on 4.1.0-0.nightly-2019-05-08-065958

The additional network can be created in the specified namespace.

spec:
  additionalNetworks:
  - name: sriov-conf
    namespace: openshift-sriov
    rawCNIConfig: '{ "type": "sriov", "name": "sriov-network",
      "ipam": { "type": "host-local", "subnet": "10.11.11.0/24", "routes": [{ "dst":
      "0.0.0.0/0" }], "gateway": "10.11.11.1" } }'
    type: Raw
  clusterNetwork:
  - cidr: 10.128.0.0/14
    hostPrefix: 23
  defaultNetwork:
    openshiftSDNConfig:
      mode: NetworkPolicy
    type: OpenShiftSDN
  serviceNetwork:
  - 172.30.0.0/16

Comment 12 errata-xmlrpc 2019-06-04 10:44:26 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0758