Bug 1680551

Summary: Successful gluster deployment message is displayed when an ansible syntax error is encountered.
Product: [oVirt] cockpit-ovirt Reporter: Mugdha Soni <musoni>
Component: GdeployAssignee: Gobinda Das <godas>
Status: CLOSED CURRENTRELEASE QA Contact: Mugdha Soni <musoni>
Severity: high Docs Contact:
Priority: unspecified    
Version: 0.12.2CC: bugs, dparth, godas, irosenzw, musoni, rhs-bugs, sabose, sankarshan, sasundar
Target Milestone: ovirt-4.3.2Flags: sasundar: ovirt-4.3?
godas: devel_ack+
Target Release: 0.12.5   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: cockpit-ovirt-0.12.5 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: 1680548 Environment:
Last Closed: 2019-03-26 07:20:51 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: Gluster RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1680548    
Attachments:
Description Flags
Video of the error .
none
Bug Verification screenshot none

Description Mugdha Soni 2019-02-25 10:08:19 UTC 
+++ This bug was initially created as a clone of Bug #1680548 +++

Description of problem:
---------------------------------
The successful gluster deployment message is  displayed in cockpit UI  when an ansible syntax error in encountered if user edit's the inventory file in review tab.
There are no volumes created and user is allowed to proceed with hosted engine deployment.

Version-Release number of selected component:
----------------------------------------------
rhvh-4.3.0.5-0.20190221
glusterfs-server-3.12.2-45
cockpit-ovirt-dashboard-0.12.2-1
gluster-ansible-cluster-1.0-1.el7

How reproducible:
-----------------
Everytime

Steps to Reproduce:
-------------------
1.Configure all the parameters required for gluster deployment in cockpit UI.
2.Add some parameter with wrong syntax in the generated ansible wizard inventory file in review tab.
3.Click on save and then deploy button.

Actual results:
------------------
The cockpit UI shows successful gluster deployment even though there are volumes created.

Expected results:
------------------
Proper error message should be displayed when there is an ansible syntax error.
Comment 1 Gobinda Das 2019-02-25 10:58:36 UTC 
Can you please mention what wrong syntax you gave in inventory file?
Comment 2 Mugdha Soni 2019-02-27 09:02:25 UTC 
Created attachment 1539087 [details]
Video of the error .
Comment 3 Gobinda Das 2019-03-04 09:43:31 UTC 
Parth,
 You need to check syntax on save of inventory file.
Ex: ansible-playbook --syntax-check xyz.yml
If syntax is correct then allow save otherwise throw error.
Comment 4 Parth Dhanjal 2019-03-04 09:47:54 UTC 
(In reply to Gobinda Das from comment #3)
> Parth,
>  You need to check syntax on save of inventory file.
> Ex: ansible-playbook --syntax-check xyz.yml
> If syntax is correct then allow save otherwise throw error.

Sure Gobinda!
Will make a function checking syntax.
Comment 5 Mugdha Soni 2019-03-20 12:17:33 UTC 
Created attachment 1546054 [details]
Bug Verification screenshot
Comment 6 Mugdha Soni 2019-03-20 12:18:27 UTC 
Tested with the following:-
glusterfs-server-3.12.2-47.el7rhgs
gluster-ansible-repositories-1.0-1.el7rhgs.noarch
gluster-ansible-maintenance-1.0.1-1.el7rhgs.noarch
gluster-ansible-features-1.0.4-5.el7rhgs.noarch
gluster-ansible-cluster-1.0-1.el7rhgs.noarch
gluster-ansible-roles-1.0.4-4.el7rhgs.noarch
gluster-ansible-infra-1.0.3-3.el7rhgs.noarch

rhvh-4.3.0.5-0.20190313

If there is any ansible syntax error then the deployment fails at the very initial point saying "ERROR! No inventory was parsed, please check your configuration and options. Could be problem in inventory file."
Error message  is displayed and the deployment doesn't proceed .

Hence ,moving the bug to verified state.
Comment 7 Sandro Bonazzola 2019-03-26 07:20:51 UTC 
This bugzilla is included in oVirt 4.3.2 release, published on March 19th 2019.

Since the problem described in this bug report should be
resolved in oVirt 4.3.2 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.