+++ This bug was initially created as a clone of Bug #1680548 +++ Description of problem: --------------------------------- The successful gluster deployment message is displayed in cockpit UI when an ansible syntax error in encountered if user edit's the inventory file in review tab. There are no volumes created and user is allowed to proceed with hosted engine deployment. Version-Release number of selected component: ---------------------------------------------- rhvh-4.3.0.5-0.20190221 glusterfs-server-3.12.2-45 cockpit-ovirt-dashboard-0.12.2-1 gluster-ansible-cluster-1.0-1.el7 How reproducible: ----------------- Everytime Steps to Reproduce: ------------------- 1.Configure all the parameters required for gluster deployment in cockpit UI. 2.Add some parameter with wrong syntax in the generated ansible wizard inventory file in review tab. 3.Click on save and then deploy button. Actual results: ------------------ The cockpit UI shows successful gluster deployment even though there are volumes created. Expected results: ------------------ Proper error message should be displayed when there is an ansible syntax error.
Can you please mention what wrong syntax you gave in inventory file?
Created attachment 1539087 [details] Video of the error .
Parth, You need to check syntax on save of inventory file. Ex: ansible-playbook --syntax-check xyz.yml If syntax is correct then allow save otherwise throw error.
(In reply to Gobinda Das from comment #3) > Parth, > You need to check syntax on save of inventory file. > Ex: ansible-playbook --syntax-check xyz.yml > If syntax is correct then allow save otherwise throw error. Sure Gobinda! Will make a function checking syntax.
Created attachment 1546054 [details] Bug Verification screenshot
Tested with the following:- glusterfs-server-3.12.2-47.el7rhgs gluster-ansible-repositories-1.0-1.el7rhgs.noarch gluster-ansible-maintenance-1.0.1-1.el7rhgs.noarch gluster-ansible-features-1.0.4-5.el7rhgs.noarch gluster-ansible-cluster-1.0-1.el7rhgs.noarch gluster-ansible-roles-1.0.4-4.el7rhgs.noarch gluster-ansible-infra-1.0.3-3.el7rhgs.noarch rhvh-4.3.0.5-0.20190313 If there is any ansible syntax error then the deployment fails at the very initial point saying "ERROR! No inventory was parsed, please check your configuration and options. Could be problem in inventory file." Error message is displayed and the deployment doesn't proceed . Hence ,moving the bug to verified state.
This bugzilla is included in oVirt 4.3.2 release, published on March 19th 2019. Since the problem described in this bug report should be resolved in oVirt 4.3.2 release, it has been closed with a resolution of CURRENT RELEASE. If the solution does not work for you, please open a new bug report.