Bug 168097

* In the URL tag, change prdownloads.sourceforge.net to dl.sf.net to allow
direct download
* Duplicate BuildRequires: qt-devel, kdelibs-devel, arts-devel, libtiff-devel,
pkgconfig, autoconf
* "make -f Makefile.cvs" is useless
* Add --disable-debug to %configure
* Install desktop file with desktop-file-install. Here's what you could use:
desktop-file-install --vendor fedora --delete-original \
  --dir $RPM_BUILD_ROOT%{_datadir}/applications \
  --add-category X-Fedora \
  --add-category Application \
  --add-category Photograph \
  --add-category Graphics \
  $RPM_BUILD_ROOT%{_datadir}/applnk/Graphics/%{name}.desktop
and for showfoto
desktop-file-install --vendor fedora --delete-original \
  --dir $RPM_BUILD_ROOT%{_datadir}/applications \
  --add-category X-Fedora \
  --add-category Application \
  --add-category Photograph \
  --add-category Graphics \
  $RPM_BUILD_ROOT%{_datadir}/applications/kde/showfoto.desktop
* The desktop file contains Mime types, so you have to add the required bits in
the scriptlets (see http://fedoraproject.org/wiki/ScriptletSnippets, section
about "desktop-database")
* The package add files in /usr/share/icons, so you also have to update gtk's
cache in the scriptlets (see http://fedoraproject.org/wiki/ScriptletSnippets,
section about "GTK+ icon cache")

New package on the server (with the same release version), all bugs should be fixed.

> New package on the server (with the same release version)

Please update the release, it makes it easier for the reviewer to say "release X
approved"

* Duplicate BuildRequires: kdelibs-devel (already required by libkexif-devel)
* Requirements: missing dependancy on gtk-update-icon-cache (package gtk2)
* since you removed make -f Makefile.cvs, you don't need automake as a BR anymore

Rex, you might be interested in this package too... (feel free to un'CC yourself
if you don't)

Thanks, I thought I had already CC'd myself, so thanks for doing it for me.  (-:

Release 2 on server with one exception:

* Requirements: missing dependancy on gtk-update-icon-cache (package gtk2)

On http://fedoraproject.org/wiki/ScriptletSnippets you can read:
"GTK+ icon cache"
"Note that _no_ dependencies should be added for this. If gtk-update-icon-cache
is not available, there's nothing that would be needing the cache update. Not
adding the dependency on gtk-update-icon-cache (ie. gtk2 >= 2.6.0) makes it
easier to use the package (or the same specfile) on systems where it's not
available nor needed, such as older distro versions or (very) trimmed down
installations."

So I didn't add requirements you mentioned.

Good point, sorry about that. Will review shortly.

Review for release 2: APPROVED
* RPM name is OK
* Source digikam-0.7.4.tar.bz2 is the same as upstream
* Builds fine in mock
* rpmlint of digikam looks OK
* rpmlint of digikam-devel looks OK
* File list of digikam looks OK
* File list of digikam-devel looks OK
* Seems to work fine

Unless Rex has something to improve, you're fine with me.

After import, please add something in %description concerning the package
kipi-plugins, like : "The image editor is extensible via plugins, install the
kipi-plugins package to use them" (adapt at will)

As I see there isn't kipi-plugins package in FC or FE. Should I add description
about something that currently don't exist in FE?

Hmm, right, my kipi-plugins rpm came from kde-redhat.
You can forget about the description for the moment, and if you feel like
packaging kipi-plugins, feel free to do so... :)

Maybe, maybe I'll package it :)

Package Change Request
======================
Package Name: digikam
New Branches: EL-5

cvs done.