Bug 1683761

Summary:	Changes to clusteringress.spec.nodePlacement are not applied
Product:	OpenShift Container Platform	Reporter:	Dan Mace <dmace>
Component:	Networking	Assignee:	Miciah Dashiel Butler Masters <mmasters>
Networking sub component:	router	QA Contact:	Hongan Li <hongli>
Status:	CLOSED ERRATA	Docs Contact:
Severity:	medium
Priority:	unspecified	CC:	akrzos, aos-bugs, mmasters
Version:	4.1.0
Target Milestone:	---
Target Release:	4.1.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-06-04 10:44:39 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dan Mace 2019-02-27 18:10:23 UTC

Description of problem:

Changes to the clusteringress.spec.nodePlacement field are not applied to the cluster.


Version-Release number of selected component (if applicable):


How reproducible:

`oc edit -n openshift-ingress-operator/default` and set a new value for `.spec.nodePlacement`.


Actual results:

The ingress-operator does not update the router deployment with the node node placement values.

Expected results:

The routers for the clusteringress should be redeployed using the new nodePlacement values.

Additional info:

Comment 3 Hongan Li 2019-03-14 06:49:04 UTC

verified with 4.0.0-0.nightly-2019-03-13-233958 and the issue has been fixed.

edit ingresscontroller and add spec.nodePlacement like below then check deployment: 
```
  spec:
    nodePlacement:
      nodeSelector:
        matchLabels:
          router: router
```

$ oc get deployment -n openshift-ingress -o yaml | grep nodeSelector -A 1
        nodeSelector:
          router: router


remove nodePlacement from ingresscontroller then the nodeSelector of deployment is restored to default:
$ oc get deployment -n openshift-ingress -o yaml | grep nodeSelector -A 2
        nodeSelector:
          beta.kubernetes.io/os: linux
          node-role.kubernetes.io/worker: ""

Comment 5 errata-xmlrpc 2019-06-04 10:44:39 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0758