Bug 1684397

Summary: Should update application-template-custombuild.json in origin repo
Product: OpenShift Container Platform Reporter: wewang <wewang>
Component: BuildAssignee: Adam Kaplan <adam.kaplan>
Status: CLOSED ERRATA QA Contact: wewang <wewang>
Severity: high Docs Contact:
Priority: medium    
Version: 4.1.0CC: aos-bugs, bparees, wzheng
Target Milestone: ---   
Target Release: 4.1.0   
Hardware: Unspecified   
OS: Unspecified   
Fixed In Version: Doc Type: No Doc Update
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-06-04 10:44:51 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:

Description wewang 2019-03-01 07:38:35 UTC
Description of problem:
With Openshift v4.0, will not provide an accessible docker socket for use within a custom build image. so should update image and remove exposeDockerSocket in  https://raw.githubusercontent.com/openshift/origin/master/examples/sample-app/application-template-custombuild.json  
Version-Release number of selected component (if applicable):

How reproducible:

Steps to Reproduce:
1. Check application-template-custombuild.json from origin repo 

Actual results:
had builder image which is build by docker 

Expected results:
should have custom image builded by buildah

Additional info:
Add new custom build cases for 4.0

Comment 1 Ben Parees 2019-03-01 14:04:21 UTC
Adam, We should just remove that sample entirely, it's being replaced by the tutorial defined in https://github.com/openshift/openshift-docs/pull/13876

Comment 2 Adam Kaplan 2019-03-06 19:23:15 UTC
PR to remove template: https://github.com/openshift/origin/pull/22261

Comment 3 wewang 2019-03-12 05:38:03 UTC
The custom related places already updated, verified it.

Comment 6 errata-xmlrpc 2019-06-04 10:44:51 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.