Bug 168593

Summary: Review Request: pydot: Python interface to Graphviz's Dot language
Product: [Fedora] Fedora Reporter: Tom "spot" Callaway <tcallawa>
Component: Package ReviewAssignee: Michael A. Peters <mpeters>
Status: CLOSED NEXTRELEASE QA Contact: David Lawrence <dkl>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: fedora-extras-list
Target Milestone: ---   
Target Release: ---   
Hardware: All   
OS: Linux   
URL: http://dkbza.org/pydot.html
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2005-10-07 05:28:05 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 163779    

Description Tom "spot" Callaway 2005-09-17 18:56:50 UTC 
Spec Name or Url: http://www.auroralinux.org/people/spot/review/pydot.spec
SRPM Name or Url: http://www.auroralinux.org/people/spot/review/pydot-0.9.10-1.src.rpm
Description: 
An interface for creating both directed and non directed graphs from Python.
Currently all attributes implemented in the Dot language are supported (up
to Graphviz 1.16).

Output can be inlined in Postscript into interactive scientific environments
like TeXmacs, or output in any of the format's supported by the Graphviz
tools dot, neato, twopi.
Comment 1 Michael A. Peters 2005-10-06 17:22:24 UTC 
md5sum matches upstream
builds clean in mock
rpmlint doesn't complain
License matches readme and license file

-=-
from the readme:

Requirements:
-------------

pyparsing: pydot requires the pyparsing module in order to be
        able to load DOT files.

GraphViz:  is needed in order to render the graphs into any of
        the plethora of output formats supported.

These are listed as BuildRequires - but yum did not pull in pyparsing (not
installed) when I ran yum localinstall, and rpm did not complain when I tried
rpm --test -e graphviz

Did you mean that to be Requires and not BuildRequires?
Comment 2 Tom "spot" Callaway 2005-10-06 17:31:30 UTC 
Yes, those should be Requires... my bad. I'll change them before commit.
Comment 3 Michael A. Peters 2005-10-07 01:20:49 UTC 
* Spec file readable
* Group appropriate
* Proper use of Macros
* Software works - tested in fc4

APPROVED w/ comment2 changes