Bug 1686877
| Summary: | [Regression][v2v] Move v2v throttling capabilities to backend | ||
|---|---|---|---|
| Product: | Red Hat CloudForms Management Engine | Reporter: | Satoe Imaishi <simaishi> |
| Component: | V2V | Assignee: | James Wong <jwong> |
| Status: | CLOSED ERRATA | QA Contact: | Yadnyawalk Tale <ytale> |
| Severity: | medium | Docs Contact: | Red Hat CloudForms Documentation <cloudforms-docs> |
| Priority: | high | ||
| Version: | 5.10.1 | CC: | bthurber, fdupont, smallamp |
| Target Milestone: | GA | Keywords: | Regression, ZStream |
| Target Release: | 5.10.2 | ||
| Hardware: | All | ||
| OS: | All | ||
| Whiteboard: | v2v | ||
| Fixed In Version: | 5.10.2.2 | Doc Type: | If docs needed, set a value |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1686155 | Environment: | |
| Last Closed: | 2019-04-02 07:46:17 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | V2V | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1686155 | ||
| Bug Blocks: | |||
|
Comment 2
CFME Bot
2019-03-08 15:16:23 UTC
New commit detected on ManageIQ/manageiq-content/hammer: https://github.com/ManageIQ/manageiq-content/commit/439d0de4be15acc18caab7a4dc6e36b6d7906d4c commit 439d0de4be15acc18caab7a4dc6e36b6d7906d4c Author: Greg McCullough <gmccullo> AuthorDate: Mon Mar 4 17:39:54 2019 -0500 Commit: Greg McCullough <gmccullo> CommitDate: Mon Mar 4 17:39:54 2019 -0500 Merge pull request #504 from jameswnl/throttle v2v Throttling moved to backend (cherry picked from commit a8f5cc3c4833c62791e329c793a1236e0b89df78) https://bugzilla.redhat.com/show_bug.cgi?id=1686877 content/automate/ManageIQ/Transformation/Common.class/__methods__/acquiretransformationhost.rb | 27 - content/automate/ManageIQ/Transformation/Common.class/__methods__/acquiretransformationhost.yaml | 15 - content/automate/ManageIQ/Transformation/Common.class/__methods__/assesstransformation.rb | 39 - content/automate/ManageIQ/Transformation/Common.class/__methods__/assesstransformation.yaml | 15 - content/automate/ManageIQ/Transformation/Common.class/__methods__/preflightcheck.rb | 25 + content/automate/ManageIQ/Transformation/Common.class/__methods__/preflightcheck.yaml | 15 + content/automate/ManageIQ/Transformation/Common.class/__methods__/vmchecktransformed.rb | 2 - content/automate/ManageIQ/Transformation/StateMachines/TransformationThrottler.class/__class__.yaml | 193 - content/automate/ManageIQ/Transformation/StateMachines/TransformationThrottler.class/default.yaml | 13 - content/automate/ManageIQ/Transformation/StateMachines/VMTransformation.class/posttransform.yaml | 28 +- content/automate/ManageIQ/Transformation/StateMachines/VMTransformation.class/pretransform.yaml | 12 +- content/automate/ManageIQ/Transformation/StateMachines/VMTransformation.class/transform.yaml | 12 +- content/automate/ManageIQ/Transformation/StateMachines/VMTransformation.class/transformation.yaml | 30 +- content/automate/ManageIQ/Transformation/TransformationThrottler.class/__class__.yaml | 33 - content/automate/ManageIQ/Transformation/TransformationThrottler.class/__methods__/throttle.rb | 22 - content/automate/ManageIQ/Transformation/TransformationThrottler.class/__methods__/throttle.yaml | 15 - content/automate/ManageIQ/Transformation/TransformationThrottler.class/__methods__/utils.rb | 154 - content/automate/ManageIQ/Transformation/TransformationThrottler.class/__methods__/utils.yaml | 13 - content/automate/ManageIQ/Transformation/TransformationThrottler.class/__methods__/watch.rb | 20 - content/automate/ManageIQ/Transformation/TransformationThrottler.class/__methods__/watch.yaml | 15 - content/automate/ManageIQ/Transformation/TransformationThrottler.class/_missing.yaml | 12 - spec/content/automate/ManageIQ/Transformation/Common.class/__methods__/acquiretransformationhost_spec.rb | 64 - spec/content/automate/ManageIQ/Transformation/Common.class/__methods__/assesstransformation_spec.rb | 246 - spec/content/automate/ManageIQ/Transformation/Common.class/__methods__/preflightcheck_spec.rb | 51 + spec/content/automate/ManageIQ/Transformation/Common.class/__methods__/vmchecktransformed_spec.rb | 22 - spec/content/automate/ManageIQ/Transformation/TransformationThrottler.class/__methods__/utils_spec.rb | 413 - 26 files changed, 128 insertions(+), 1378 deletions(-) Checked with @Fabian and @James's fix for 5.10.2 migration, throttling was not working. Marking FailedQA. More info https://gitter.im/ManageIQ/v2v?at=5c90d02952c7a91455bd13d1. Checked on 5.10.2.0.20190311164858_455d270. Thanks to @Fabien for confirming, devels are currently working on this. Fix ConversionHost active_tasks method to use state == 'migrate' - https://github.com/ManageIQ/manageiq/pull/18570 New commit detected on ManageIQ/manageiq/hammer: https://github.com/ManageIQ/manageiq/commit/4304a7d679db4573a8053e33c57b3d3cde9b683d commit 4304a7d679db4573a8053e33c57b3d3cde9b683d Author: Adam Grare <agrare> AuthorDate: Tue Mar 19 09:44:31 2019 -0400 Commit: Adam Grare <agrare> CommitDate: Tue Mar 19 09:44:31 2019 -0400 Merge pull request #18570 from fdupont-redhat/v2v_throttling_use_migrate_state [V2V] Fix ConversionHost active_tasks method to use state == 'migrate' (cherry picked from commit 7407f63a81dca3c7aa67cfeb84dce39da9392d5b) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1686877 app/models/conversion_host.rb | 2 +- spec/models/conversion_host_spec.rb | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Verified! Tested OSP13 and RHV42 with 5.10.2.2.20190319204241_4304a7d. I saw throttling not working this morning but after some debug found that it was ems_ref error and after deleting plan it worked normally. Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2019:0694 |