Bug 1686877 - [Regression][v2v] Move v2v throttling capabilities to backend
Summary: [Regression][v2v] Move v2v throttling capabilities to backend
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat CloudForms Management Engine
Classification: Red Hat
Component: V2V
Version: 5.10.1
Hardware: All
OS: All
high
medium
Target Milestone: GA
: 5.10.2
Assignee: James Wong
QA Contact: Yadnyawalk Tale
Red Hat CloudForms Documentation
URL:
Whiteboard: v2v
Depends On: 1686155
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-03-08 15:10 UTC by Satoe Imaishi
Modified: 2019-04-11 10:45 UTC (History)
3 users (show)

Fixed In Version: 5.10.2.2
Doc Type: If docs needed, set a value
Doc Text:
Clone Of: 1686155
Environment:
Last Closed: 2019-04-02 07:46:17 UTC
Category: ---
Cloudforms Team: V2V
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Red Hat Product Errata RHBA-2019:0694 0 None None None 2019-04-02 07:46:22 UTC

Comment 2 CFME Bot 2019-03-08 15:16:23 UTC
New commit detected on ManageIQ/manageiq/hammer:

https://github.com/ManageIQ/manageiq/commit/d1585b3a59c31d58ee0412fa8ef4daa5c1a26df2
commit d1585b3a59c31d58ee0412fa8ef4daa5c1a26df2
Author:     Adam Grare <agrare>
AuthorDate: Wed Feb 27 15:46:02 2019 -0500
Commit:     Adam Grare <agrare>
CommitDate: Wed Feb 27 15:46:02 2019 -0500

    Merge pull request #18415 from jameswnl/throttle

    v2v Throttling

    (cherry picked from commit e3e7c38b24a445f50ded7bf15438fadd0da9294a)

    https://bugzilla.redhat.com/show_bug.cgi?id=1686877

 app/models/infra_conversion_job.rb | 155 +
 app/models/job_proxy_dispatcher.rb | 5 +
 app/models/service_template_transformation_plan_request.rb | 12 +
 app/models/service_template_transformation_plan_task.rb | 77 +-
 lib/infra_conversion_throttler.rb | 24 +
 spec/factories/job.rb | 7 +
 spec/lib/infra_conversion_throttler_spec.rb | 50 +
 spec/models/infra_conversion_job_spec.rb | 207 +
 spec/models/service_template_transformation_plan_task_spec.rb | 57 +-
 9 files changed, 560 insertions(+), 34 deletions(-)


https://github.com/ManageIQ/manageiq/commit/b85a83f8b0dc06fc53efd9eab874405a53cbc381
commit b85a83f8b0dc06fc53efd9eab874405a53cbc381
Author:     Adam Grare <agrare>
AuthorDate: Tue Mar  5 16:22:22 2019 -0500
Commit:     Adam Grare <agrare>
CommitDate: Tue Mar  5 16:22:22 2019 -0500

    Merge pull request #18521 from jameswnl/fix-spec

    Fixing a spec failure

    (cherry picked from commit 1817c2088ad52016a53c119291a13692cc4be2de)

    https://bugzilla.redhat.com/show_bug.cgi?id=1686877

 spec/factories/job.rb | 2 +-
 spec/factories/miq_request_task.rb | 4 +
 2 files changed, 5 insertions(+), 1 deletion(-)

Comment 3 CFME Bot 2019-03-08 15:32:55 UTC
New commit detected on ManageIQ/manageiq-content/hammer:

https://github.com/ManageIQ/manageiq-content/commit/439d0de4be15acc18caab7a4dc6e36b6d7906d4c
commit 439d0de4be15acc18caab7a4dc6e36b6d7906d4c
Author:     Greg McCullough <gmccullo>
AuthorDate: Mon Mar  4 17:39:54 2019 -0500
Commit:     Greg McCullough <gmccullo>
CommitDate: Mon Mar  4 17:39:54 2019 -0500

    Merge pull request #504 from jameswnl/throttle

    v2v Throttling moved to backend

    (cherry picked from commit a8f5cc3c4833c62791e329c793a1236e0b89df78)

    https://bugzilla.redhat.com/show_bug.cgi?id=1686877

 content/automate/ManageIQ/Transformation/Common.class/__methods__/acquiretransformationhost.rb | 27 -
 content/automate/ManageIQ/Transformation/Common.class/__methods__/acquiretransformationhost.yaml | 15 -
 content/automate/ManageIQ/Transformation/Common.class/__methods__/assesstransformation.rb | 39 -
 content/automate/ManageIQ/Transformation/Common.class/__methods__/assesstransformation.yaml | 15 -
 content/automate/ManageIQ/Transformation/Common.class/__methods__/preflightcheck.rb | 25 +
 content/automate/ManageIQ/Transformation/Common.class/__methods__/preflightcheck.yaml | 15 +
 content/automate/ManageIQ/Transformation/Common.class/__methods__/vmchecktransformed.rb | 2 -
 content/automate/ManageIQ/Transformation/StateMachines/TransformationThrottler.class/__class__.yaml | 193 -
 content/automate/ManageIQ/Transformation/StateMachines/TransformationThrottler.class/default.yaml | 13 -
 content/automate/ManageIQ/Transformation/StateMachines/VMTransformation.class/posttransform.yaml | 28 +-
 content/automate/ManageIQ/Transformation/StateMachines/VMTransformation.class/pretransform.yaml | 12 +-
 content/automate/ManageIQ/Transformation/StateMachines/VMTransformation.class/transform.yaml | 12 +-
 content/automate/ManageIQ/Transformation/StateMachines/VMTransformation.class/transformation.yaml | 30 +-
 content/automate/ManageIQ/Transformation/TransformationThrottler.class/__class__.yaml | 33 -
 content/automate/ManageIQ/Transformation/TransformationThrottler.class/__methods__/throttle.rb | 22 -
 content/automate/ManageIQ/Transformation/TransformationThrottler.class/__methods__/throttle.yaml | 15 -
 content/automate/ManageIQ/Transformation/TransformationThrottler.class/__methods__/utils.rb | 154 -
 content/automate/ManageIQ/Transformation/TransformationThrottler.class/__methods__/utils.yaml | 13 -
 content/automate/ManageIQ/Transformation/TransformationThrottler.class/__methods__/watch.rb | 20 -
 content/automate/ManageIQ/Transformation/TransformationThrottler.class/__methods__/watch.yaml | 15 -
 content/automate/ManageIQ/Transformation/TransformationThrottler.class/_missing.yaml | 12 -
 spec/content/automate/ManageIQ/Transformation/Common.class/__methods__/acquiretransformationhost_spec.rb | 64 -
 spec/content/automate/ManageIQ/Transformation/Common.class/__methods__/assesstransformation_spec.rb | 246 -
 spec/content/automate/ManageIQ/Transformation/Common.class/__methods__/preflightcheck_spec.rb | 51 +
 spec/content/automate/ManageIQ/Transformation/Common.class/__methods__/vmchecktransformed_spec.rb | 22 -
 spec/content/automate/ManageIQ/Transformation/TransformationThrottler.class/__methods__/utils_spec.rb | 413 -
 26 files changed, 128 insertions(+), 1378 deletions(-)

Comment 4 Yadnyawalk Tale 2019-03-19 12:49:45 UTC
Checked with @Fabian and @James's fix for 5.10.2 migration, throttling was not working.

Marking FailedQA. More info https://gitter.im/ManageIQ/v2v?at=5c90d02952c7a91455bd13d1.
Checked on 5.10.2.0.20190311164858_455d270.

Thanks to @Fabien for confirming, devels are currently working on this.

Comment 5 Fabien Dupont 2019-03-19 12:51:41 UTC
Fix ConversionHost active_tasks method to use state == 'migrate' - https://github.com/ManageIQ/manageiq/pull/18570

Comment 8 CFME Bot 2019-03-19 19:11:07 UTC
New commit detected on ManageIQ/manageiq/hammer:

https://github.com/ManageIQ/manageiq/commit/4304a7d679db4573a8053e33c57b3d3cde9b683d
commit 4304a7d679db4573a8053e33c57b3d3cde9b683d
Author:     Adam Grare <agrare>
AuthorDate: Tue Mar 19 09:44:31 2019 -0400
Commit:     Adam Grare <agrare>
CommitDate: Tue Mar 19 09:44:31 2019 -0400

    Merge pull request #18570 from fdupont-redhat/v2v_throttling_use_migrate_state

    [V2V] Fix ConversionHost active_tasks method to use state == 'migrate'

    (cherry picked from commit 7407f63a81dca3c7aa67cfeb84dce39da9392d5b)

    Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1686877

 app/models/conversion_host.rb | 2 +-
 spec/models/conversion_host_spec.rb | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comment 9 Yadnyawalk Tale 2019-03-22 15:04:17 UTC
Verified! Tested OSP13 and RHV42 with 5.10.2.2.20190319204241_4304a7d.
I saw throttling not working this morning but after some debug found that it was ems_ref error and after deleting plan it worked normally.

Comment 11 errata-xmlrpc 2019-04-02 07:46:17 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2019:0694


Note You need to log in before you can comment on or make changes to this bug.