Bug 1687384
| Summary: | pytest FTBFS (not only with Python 3.8) | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Miro Hrončok <mhroncok> | ||||||||
| Component: | pytest | Assignee: | Miro Hrončok <mhroncok> | ||||||||
| Status: | CLOSED RAWHIDE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||
| Severity: | unspecified | Docs Contact: | |||||||||
| Priority: | unspecified | ||||||||||
| Version: | rawhide | CC: | mrunge, thomas.moschny | ||||||||
| Target Milestone: | --- | ||||||||||
| Target Release: | --- | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Whiteboard: | |||||||||||
| Fixed In Version: | pytest-4.3.1-1.fc31 | Doc Type: | If docs needed, set a value | ||||||||
| Doc Text: | Story Points: | --- | |||||||||
| Clone Of: | Environment: | ||||||||||
| Last Closed: | 2019-04-09 10:58:56 UTC | Type: | Bug | ||||||||
| Regression: | --- | Mount Type: | --- | ||||||||
| Documentation: | --- | CRM: | |||||||||
| Verified Versions: | Category: | --- | |||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||
| Embargoed: | |||||||||||
| Bug Depends On: | 1671167 | ||||||||||
| Bug Blocks: | 1686977 | ||||||||||
| Attachments: |
|
||||||||||
BTW I need pytest to build to bootstrap Python 3.8. Created attachment 1542862 [details]
build.log from copr
Created attachment 1542863 [details]
root.log from copr
Note: In rawhide, there is a separate test failure with Python 3.7. In copr with Python 3.8, the python2 tests fail to run. More importantly, there are 5 failed tests on Python 3.8. I think we need to bump pytest to 4.x https://github.com/pytest-dev/pytest/commit/0c5e717f43151852efb08ac72b0f0691443ab352 Will attach build.log. Created attachment 1542917 [details]
build.log from copr, Python 3.8 tests first
I've solved the Python 2 failure: mock is no longer an optional test dependency on Python 2. Another failure: https://github.com/pytest-dev/pytest/issues/4913 Another (already fixed) failure: https://github.com/pytest-dev/pytest/issues/4716 |
pytest-3.9.3-3.fc31 FTBFS, Python 2 tests give: import unittest.mock as mock E ImportError: No module named mock That is kinda expected as this was added in Python 3. Yet it used to work. + /builddir/build/BUILDROOT/pytest-3.9.3-3.fc31.x86_64/usr/bin/pytest-2.7 -r s testing ============================= test session starts ============================== platform linux2 -- Python 2.7.16, pytest-3.9.3, py-1.7.0, pluggy-0.8.1 hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/builddir/build/BUILD/pytest-3.9.3/.hypothesis/examples') rootdir: /builddir/build/BUILD/pytest-3.9.3, inifile: tox.ini plugins: hypothesis-4.9.0 collected 2185 items / 2 errors ==================================== ERRORS ==================================== ____________________ ERROR collecting testing/test_mark.py _____________________ ImportError while importing test module '/builddir/build/BUILD/pytest-3.9.3/testing/test_mark.py'. Hint: make sure your test modules/packages have valid Python names. Traceback: /usr/lib/python2.7/site-packages/six.py:709: in exec_ exec("""exec _code_ in _globs_, _locs_""") testing/test_mark.py:11: in <module> import unittest.mock as mock E ImportError: No module named mock __________________ ERROR collecting testing/code/test_code.py __________________ ImportError while importing test module '/builddir/build/BUILD/pytest-3.9.3/testing/code/test_code.py'. Hint: make sure your test modules/packages have valid Python names. Traceback: /usr/lib/python2.7/site-packages/six.py:709: in exec_ exec("""exec _code_ in _globs_, _locs_""") testing/code/test_code.py:17: in <module> import unittest.mock as mock E ImportError: No module named mock !!!!!!!!!!!!!!!!!!! Interrupted: 2 errors during collection !!!!!!!!!!!!!!!!!!!! =========================== 2 error in 4.99 seconds ============================ https://apps.fedoraproject.org/koschei/package/pytest I suspect the update to python2-six 1.11.0-7.fc30. Fresh scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=33397478 seems to get past the failure, will investigate.