Bug 1688068

Summary: Proper error message needed for FUSE mount failure when /var is filled.
Product: [Community] GlusterFS Reporter: Amar Tumballi <atumball>
Component: fuseAssignee: Amar Tumballi <atumball>
Status: CLOSED NEXTRELEASE QA Contact:
Severity: low Docs Contact:
Priority: low    
Version: mainlineCC: bugs
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-03-29 07:25:36 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1685406    

Description Amar Tumballi 2019-03-13 04:03:59 UTC
This bug was initially created as a copy of Bug #1685406


Description of problem:
On a gluster client, if we try to mount volume when /var is filled completely FUSE mount fails with:
################################################################################
# mount.glusterfs my-node.redhat.com:/testvol_replicated/ bug/
ERROR: failed to create logfile "/var/log/glusterfs/bug-.log" (No space left on device)
ERROR: failed to open logfile /var/log/glusterfs/bug-.log
Mount failed. Please check the log file for more details.
################################################################################

Instead of which a proper error message should be displayed like:
################################################################################
# mount.glusterfs my-node.redhat.com:/testvol_replicated/ bug/
ERROR: failed to create logfile "/var/log/glusterfs/bug-.log" (No space left on device)
ERROR: failed to open logfile /var/log/glusterfs/bug-.log
Mount failed as no space left on device please free disk space. 
################################################################################
As the present error message is misleading.


How reproducible:
1/1

Steps to Reproduce:
1. Create one volume of any type and start it. 
2. On the client node fill /var/log using fallocate.
3. Try to mount the volume on the client.



--- Discussions in above bug ---

> > # mount.glusterfs dhcp35-137.lab.eng.blr.redhat.com:/testvol_replicated/ bug/
> > ERROR: failed to create logfile "/var/log/glusterfs/bug-.log" (No space left on device)
> 
> 
> Doesn't the above line capture the 'issue' at hand?


In that case I would not want the error message "Mount failed. Please check the log file for more details." to be displayed at all. Because it would create confusion for when read by the user, as log-file creation itself failed.

Comment 1 Worker Ant 2019-03-13 04:08:43 UTC
REVIEW: https://review.gluster.org/22346 (mount.glusterfs: change the error message) posted (#1) for review on master by Amar Tumballi

Comment 2 Worker Ant 2019-03-29 07:25:36 UTC
REVIEW: https://review.gluster.org/22346 (mount.glusterfs: change the error message) merged (#2) on master by Amar Tumballi