Bug 1689081
| Summary: | Review Request: golang-github-xorm-core - Lightweight Go sql.DB wrapper | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Nathan Scott <nathans> |
| Component: | Package Review | Assignee: | Robert-André Mauchin 🐧 <eclipseo> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | eclipseo, lberk, mgoodwin, package-review, quantum.analyst |
| Target Milestone: | --- | Flags: | eclipseo:
fedora-review+
|
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | If docs needed, set a value | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2019-03-18 23:37:48 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1670656 | ||
|
Description
Nathan Scott
2019-03-15 05:54:31 UTC
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=33503810 (also, kudos to lberk who did the initial work here - thanks Lukas!) - Watch out for the %{goname} macro: it erases "go" and doublons from package name. Look at the produced SRPM:
golang-github-xorm-core-0.6.2-1.20190314gitccc80c1.fc29.src.rpm
Hence the SPEC and this bug should be renamed to golang-github-xorm-core.
Regenerate the SRPM afterwards so it contains the correct name.
Any reasons to package a dev snapshot instead of the latest release - License should be: License: BSD List of licenses shorthand here: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses Thanks for those tips - all fixed (I can see no reason for using a snapshot either, its the same as v0.6.2). Spec URL: https://nathans.fedorapeople.org/core/golang-github-xorm-core.spec SRPM URL: https://nathans.fedorapeople.org/core/golang-github-xorm-core-0.6.2-1.fc29.src.rpm Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=33504660 - License ok - Latest version packaged - Builds in mock - No rpmlint errors - Conforms to Packaging Guidelines Package approved. Please add your Go packages to the Go SIG, Anitya and Koschei. (fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-xorm-core golang-github-xorm-core-0.6.2-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-32e4771973 golang-github-xorm-core-0.6.2-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-d45041f855 golang-github-xorm-core-0.6.2-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-d45041f855 golang-github-xorm-core-0.6.2-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report. See https://fedoraproject.org/wiki/QA:Updates_Testing for instructions on how to install test updates. You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-32e4771973 golang-github-xorm-core-0.6.2-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report. golang-github-xorm-core-0.6.2-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report. |