Bug 1689081 - Review Request: golang-github-xorm-core - Lightweight Go sql.DB wrapper
Summary: Review Request: golang-github-xorm-core - Lightweight Go sql.DB wrapper
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1670656
TreeView+ depends on / blocked
 
Reported: 2019-03-15 05:54 UTC by Nathan Scott
Modified: 2019-04-22 05:09 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2019-03-18 23:37:48 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description Nathan Scott 2019-03-15 05:54:31 UTC
Spec URL: https://nathans.fedorapeople.org/core/golang-github-go-xorm-core.spec
SRPM URL: https://nathans.fedorapeople.org/core/golang-github-xorm-core-0.6.2-1.20190314gitccc80c1.fc29.src.rpm

Description: Lightweight Go sql.DB wrapper
Fedora Account System Username: nathans

Comment 1 Nathan Scott 2019-03-15 06:10:07 UTC
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=33503810

(also, kudos to lberk who did the initial work here - thanks Lukas!)

Comment 2 Robert-André Mauchin 🐧 2019-03-15 06:20:45 UTC
 - Watch out for the %{goname} macro: it erases "go" and doublons from package name. Look at the produced SRPM:

golang-github-xorm-core-0.6.2-1.20190314gitccc80c1.fc29.src.rpm

Hence the SPEC and this bug should be renamed to golang-github-xorm-core.

Regenerate the SRPM afterwards so it contains the correct name.

Comment 3 Robert-André Mauchin 🐧 2019-03-15 06:21:36 UTC
Any reasons to package a dev snapshot instead of the latest release

Comment 4 Robert-André Mauchin 🐧 2019-03-15 06:22:29 UTC
 - License should be:

License:        BSD


List of licenses shorthand here: https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses

Comment 5 Nathan Scott 2019-03-15 07:00:24 UTC
Thanks for those tips - all fixed (I can see no reason for using a snapshot either, its the same as v0.6.2).

Spec URL: https://nathans.fedorapeople.org/core/golang-github-xorm-core.spec
SRPM URL: https://nathans.fedorapeople.org/core/golang-github-xorm-core-0.6.2-1.fc29.src.rpm
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=33504660

Comment 6 Robert-André Mauchin 🐧 2019-03-18 00:56:12 UTC
 - License ok
 - Latest version packaged
 - Builds in mock
 - No rpmlint errors
 - Conforms to Packaging Guidelines

Package approved.

Please add your Go packages to the Go SIG, Anitya and Koschei.

Comment 7 Gwyn Ciesla 2019-03-18 13:33:58 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-xorm-core

Comment 8 Fedora Update System 2019-04-10 05:08:02 UTC
golang-github-xorm-core-0.6.2-1.fc29 has been submitted as an update to Fedora 29. https://bodhi.fedoraproject.org/updates/FEDORA-2019-32e4771973

Comment 9 Fedora Update System 2019-04-10 05:08:25 UTC
golang-github-xorm-core-0.6.2-1.fc30 has been submitted as an update to Fedora 30. https://bodhi.fedoraproject.org/updates/FEDORA-2019-d45041f855

Comment 10 Fedora Update System 2019-04-12 02:46:54 UTC
golang-github-xorm-core-0.6.2-1.fc30 has been pushed to the Fedora 30 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-d45041f855

Comment 11 Fedora Update System 2019-04-12 03:55:45 UTC
golang-github-xorm-core-0.6.2-1.fc29 has been pushed to the Fedora 29 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2019-32e4771973

Comment 12 Fedora Update System 2019-04-16 03:54:57 UTC
golang-github-xorm-core-0.6.2-1.fc30 has been pushed to the Fedora 30 stable repository. If problems still persist, please make note of it in this bug report.

Comment 13 Fedora Update System 2019-04-22 05:09:29 UTC
golang-github-xorm-core-0.6.2-1.fc29 has been pushed to the Fedora 29 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.