Bug 169190

Summary:	compiler notices dodgy code
Product:	[Fedora] Fedora	Reporter:	David Binderman <dcb314>
Component:	kdeutils	Assignee:	Than Ngo <than>
Status:	CLOSED UPSTREAM	QA Contact:	Ben Levenson <benl>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mgarski
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2005-10-27 19:53:44 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description David Binderman 2005-09-24 11:21:56 UTC

Description of problem:
I just tried to compile Fedora development package kdeutils-3.4.2-2
with the extra compiler flag -Wall.

The compiler said

hexprinter.cc:136: warning: 'size$height' is used uninitialized in this function

The source code is

SPageSize CHexPrinter::pageFullSize( void )
{
  QPaintDeviceMetrics metric( this );
  SPageSize size;
  size.width = metric.width();
  size.width = metric.height();

  return( size );
}

Notice that size.width gets assigned to twice. Maybe size.height was
intended on the second initialisation ?

  size.width = metric.width();
  size.height = metric.height();


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Marcin Garski 2005-10-27 19:53:44 UTC

Thanks for the bug report.

Bug has been reported upstream:
http://bugs.kde.org/show_bug.cgi?id=115227

I will notify when this bugs will be fixed upstream.

Comment 2 Marcin Garski 2005-10-27 23:39:18 UTC

Bug has been fixed in KDE's SVN.