Bug 1692801

Summary:	Deleting a disk from a VM in RHV fails in CFME
Product:	Red Hat CloudForms Management Engine	Reporter:	Angelina Vasileva <anikifor>
Component:	Providers	Assignee:	Boriso <bodnopoz>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Angelina Vasileva <anikifor>
Severity:	high	Docs Contact:	Red Hat CloudForms Documentation <cloudforms-docs>
Priority:	high
Version:	5.10.2	CC:	dmetzger, jfrey, jhardy, mperina, obarenbo, wfitzger
Target Milestone:	GA	Keywords:	Regression, TestOnly, ZStream
Target Release:	5.11.0
Hardware:	All
OS:	All
Whiteboard:
Fixed In Version:	5.11.0.1	Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:
Clones:	1695629 (view as bug list)		Environment:
Last Closed:	2019-12-13 15:16:39 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	Bug
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	RHEVM	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1695629

Description Angelina Vasileva 2019-03-26 13:28:22 UTC

Description of problem:
It's not possible to remove the disk from RHV VM, it throws an error that disk doesn't exist.

Version-Release number of selected component (if applicable):
CFME 5.10.2.2.20190319204241_4304a7d
RHV 4.3.2-0.1.el7

How reproducible:
Always

Steps to Reproduce:
1. Add RHV provider
2. Select a VM and power it down 
3. Do Configuration -> Reconfigure this VM, add a disk (I did thick, 10G)
4. Wait for the disk to be added
5. Configuration -> Reconfigure this VM, remove the disk added in step 3

Actual results:
Error: no disk with the name 14f9dd47-76c8-4b7a-a3b1-7f99a922f45f is attached to the vm

Expected results:
The disk is successfully removed

Additional info:
I am able to remove this disk from RHV itself.
Possibly, the issue is because it shows ID instead of name.

Comment 3 Angelina Vasileva 2019-03-26 13:42:39 UTC

Updates:
This bug is potentially related to https://bugzilla.redhat.com/show_bug.cgi?id=1691635

The bug is true for RHV both 4.2 and 4.3.

This is a regression as it works at least in 5.9.9.1.20190304164243_28a581b and (according to previous test results in cfme-5.10.1.2)

Comment 6 William Fitzgerald 2019-03-28 14:00:53 UTC

Reproducer: 10.8.196.145 version 5.10.2.2.20190319204241_4304a7d


I tried to remove a disk using rhev 4.2 and it failed:



[----] E, [2019-03-28T09:46:36.201252 #15087:866f50] ERROR -- : Q-task_id([r3_vm_reconfigure_task_3]) MIQ(VmReconfigureTask#execute) [Error: no disk with the name d3a32982-8e7c-458d-817e-b6bc117f40f0 is attached to the vm: billy_demo1] encountered during VM Reconfigure
[----] E, [2019-03-28T09:46:36.201543 #15087:866f50] ERROR -- : Q-task_id([r3_vm_reconfigure_task_3]) [RuntimeError]: no disk with the name d3a32982-8e7c-458d-817e-b6bc117f40f0 is attached to the vm: billy_demo1  Method:[block (2 levels) in <class:LogProxy>]
[----] E, [2019-03-28T09:46:36.201772 #15087:866f50] ERROR -- : Q-task_id([r3_vm_reconfigure_task_3]) /opt/rh/cfme-gemset/bundler/gems/cfme-providers-ovirt-292239cc99e4/app/models/manageiq/providers/redhat/infra_manager/ovirt_services/strategies/v4.rb:832:in `block in remove_vm_disks'
/opt/rh/cfme-gemset/bundler/gems/cfme-providers-ovirt-292239cc99e4/app/models/manageiq/providers/redhat/infra_manager/ovirt_services/strategies/v4.rb:828:in `each'
/opt/rh/cfme-gemset/bundler/gems/cfme-providers-ovirt-292239cc99e4/app/models/manageiq/providers/redhat/infra_manager/ovirt_services/strategies/v4.rb:828:in `remove_vm_disks'
/opt/rh/cfme-gemset/bundler/gems/cfme-providers-ovirt-292239cc99e4/app/models/manageiq/providers/redhat/infra_manager/ovirt_services/strategies/v4.rb:299:in `block in vm_reconfigure'
/var/www/miq/vmdb/app/models/mixins/provider_object_mixin.rb:15:in `block in with_provider_object'
/var/www/miq/vmdb/app/models/ext_management_system.rb:413:in `with_provider_connection'
/var/www/miq/vmdb/app/models/mixins/provider_object_mixin.rb:12:in `with_provider_object'
/opt/rh/cfme-gemset/bundler/gems/cfme-providers-ovirt-292239cc99e4/app/models/manageiq/providers/redhat/infra_manager/ovirt_services/strategies/v4.rb:271:in `vm_reconfigure'
/opt/rh/cfme-gemset/bundler/gems/cfme-providers-ovirt-292239cc99e4/app/models/manageiq/providers/redhat/infra_manager.rb:155:in `vm_reconfigure'
/var/www/miq/vmdb/app/models/vm_or_template.rb:351:in `run_command_via_parent'
/var/www/miq/vmdb/app/models/vm_or_template/operations/configuration.rb:124:in `spec_reconfigure'
/var/www/miq/vmdb/app/models/vm_reconfigure_task.rb:50:in `do_request'
/var/www/miq/vmdb/app/models/miq_request_task.rb:205:in `execute'
/var/www/miq/vmdb/app/models/miq_queue.rb:455:in `block in dispatch_method'
/usr/share/ruby/timeout.rb:93:in `block in timeout'
/usr/share/ruby/timeout.rb:33:in `block in catch'
/usr/share/ruby/timeout.rb:33:in `catch'
/usr/share/ruby/timeout.rb:33:in `catch'
/usr/share/ruby/timeout.rb:108:in `timeout'
/var/www/miq/vmdb/app/models/miq_queue.rb:453:in `dispatch_method'
/var/www/miq/vmdb/app/models/miq_queue.rb:430:in `block in deliver'
/var/www/miq/vmdb/app/models/user.rb:275:in `with_user_group'
/var/www/miq/vmdb/app/models/miq_queue.rb:430:in `deliver'
/var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:104:in `deliver_queue_message'
/var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:137:in `deliver_message'
/var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:155:in `block in do_work'
/var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:149:in `loop'
/var/www/miq/vmdb/app/models/miq_queue_worker_base/runner.rb:149:in `do_work'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:329:in `block in do_work_loop'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:326:in `loop'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:326:in `do_work_loop'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:153:in `run'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:127:in `start'
/var/www/miq/vmdb/app/models/miq_worker/runner.rb:22:in `start_worker'
/var/www/miq/vmdb/app/models/miq_worker.rb:408:in `block in start_runner_via_fork'
/opt/rh/cfme-gemset/gems/nakayoshi_fork-0.0.4/lib/nakayoshi_fork.rb:23:in `fork'
/opt/rh/cfme-gemset/gems/nakayoshi_fork-0.0.4/lib/nakayoshi_fork.rb:23:in `fork'
/var/www/miq/vmdb/app/models/miq_worker.rb:406:in `start_runner_via_fork'
/var/www/miq/vmdb/app/models/miq_worker.rb:396:in `start_runner'
/var/www/miq/vmdb/app/models/miq_worker.rb:447:in `start'
/var/www/miq/vmdb/app/models/miq_worker.rb:277:in `start_worker'
/var/www/miq/vmdb/app/models/miq_worker.rb:154:in `block in sync_workers'
/var/www/miq/vmdb/app/models/miq_worker.rb:154:in `times'
/var/www/miq/vmdb/app/models/miq_worker.rb:154:in `sync_workers'

Comment 7 CFME Bot 2019-03-31 13:06:31 UTC

https://github.com/ManageIQ/manageiq-providers-ovirt/pull/353

Comment 8 CFME Bot 2019-04-02 07:26:42 UTC

New commit detected on ManageIQ/manageiq-providers-ovirt/master:

https://github.com/ManageIQ/manageiq-providers-ovirt/commit/f1bf953e5278542e98bc57b16006f6dffa5c6aa6
commit f1bf953e5278542e98bc57b16006f6dffa5c6aa6
Author:     Boris Odnopozov <bodnopoz>
AuthorDate: Sun Mar 31 08:46:52 2019 -0400
Commit:     Boris Odnopozov <bodnopoz>
CommitDate: Sun Mar 31 08:46:52 2019 -0400

    Fix removing a disk from a Vm

    Make remove disk work both through the API and the UI.

    Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1692801

 app/models/manageiq/providers/redhat/infra_manager/ovirt_services/strategies/v4.rb | 21 +-
 spec/models/manageiq/providers/redhat/infra_manager/ovirt_services/strategies/v4_spec.rb | 25 +-
 2 files changed, 23 insertions(+), 23 deletions(-)

Comment 10 Angelina Vasileva 2019-05-02 15:17:13 UTC

Fixed and verified in 5.11.0.2.20190430174828_0e34dea