Bug 1693486

Summary: html5lib cannot be tested with pytest 4
Product: [Fedora] Fedora Reporter: Miro Hrončok <mhroncok>
Component: python-html5libAssignee: Miro Hrončok <mhroncok>
Status: CLOSED RAWHIDE QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: rawhideCC: anto.trande, cstratak, dan, kumarpraveen.nitdgp, metherid, mhroncok, michel, pj.pandit, python-sig
Target Milestone: ---   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: python-html5lib-1.0.1-4.fc31 Doc Type: If docs needed, set a value
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2019-07-29 23:28:15 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1671167, 1686977    

Description Miro Hrončok 2019-03-28 00:24:44 UTC
+ /usr/bin/python3 -m pytest
============================= test session starts ==============================
platform linux -- Python 3.8.0a3, pytest-4.3.0, py-1.7.0, pluggy-0.9.0
rootdir: /builddir/build/BUILD/html5lib-1.0.1, inifile: pytest.ini
plugins: expect-1.1.0
collected 31265 items / 1 errors / 31264 selected

==================================== ERRORS ====================================
________________ ERROR collecting html5lib/tests/test_stream.py ________________
/usr/lib/python3.8/site-packages/pluggy/hooks.py:289: in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
/usr/lib/python3.8/site-packages/pluggy/manager.py:68: in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
/usr/lib/python3.8/site-packages/pluggy/manager.py:59: in <lambda>
    self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
/usr/lib/python3.8/site-packages/_pytest/python.py:226: in pytest_pycollect_makeitem
    res = list(collector._genfunctions(name, obj))
/usr/lib/python3.8/site-packages/_pytest/python.py:403: in _genfunctions
    self.ihook.pytest_generate_tests(metafunc=metafunc)
/usr/lib/python3.8/site-packages/pluggy/hooks.py:289: in __call__
    return self._hookexec(self, self.get_hookimpls(), kwargs)
/usr/lib/python3.8/site-packages/pluggy/manager.py:68: in _hookexec
    return self._inner_hookexec(hook, methods, kwargs)
/usr/lib/python3.8/site-packages/pluggy/manager.py:59: in <lambda>
    self._inner_hookexec = lambda hook, methods, kwargs: hook.multicall(
/usr/lib/python3.8/site-packages/_pytest/python.py:133: in pytest_generate_tests
    metafunc.parametrize(*marker.args, **marker.kwargs)
/usr/lib/python3.8/site-packages/_pytest/python.py:990: in parametrize
    argnames, parameters = ParameterSet._for_parametrize(
/usr/lib/python3.8/site-packages/_pytest/mark/structures.py:114: in _for_parametrize
    if len(param.values) != len(argnames):
E   TypeError: object of type 'MarkDecorator' has no len()
=============================== warnings summary ===============================
html5lib/tests/test_encoding.py:98
  html5lib/tests/test_encoding.py:98: PytestWarning: yield tests were removed in pytest 4.0 - test_encoding will be ignored
    def test_encoding():

html5lib/tests/test_sanitizer.py:62
  html5lib/tests/test_sanitizer.py:62: PytestWarning: yield tests were removed in pytest 4.0 - test_sanitizer will be ignored
    def test_sanitizer():

html5lib/tests/test_serializer.py:220
  html5lib/tests/test_serializer.py:220: PytestWarning: yield tests were removed in pytest 4.0 - test_serializer will be ignored
    def test_serializer():

html5lib/tests/test_treewalkers.py:81
  html5lib/tests/test_treewalkers.py:81: PytestWarning: yield tests were removed in pytest 4.0 - test_treewalker_six_mix will be ignored
    def test_treewalker_six_mix():

-- Docs: https://docs.pytest.org/en/latest/warnings.html
=========================== short test summary info ============================
FAILED html5lib/tests/test_stream.py
!!!!!!!!!!!!!!!!!!! Interrupted: 1 errors during collection !!!!!!!!!!!!!!!!!!!!
===================== 4 warnings, 1 error in 3.64 seconds ======================

Comment 1 Charalampos Stratakis 2019-06-25 13:46:22 UTC
We should backport the PR to Fedora to fix the issue, as upstream do not answer to queries so far.