Bug 1693604

Summary:	Review Request: falkon-pdfreader - PDF reader extension for Falkon using pdf.js
Product:	[Fedora] Fedora	Reporter:	Vasiliy Glazov <vascom2>
Component:	Package Review	Assignee:	Vitaly <vitaly>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rawhide	CC:	package-review, vitaly
Target Milestone:	---	Flags:	vitaly: fedora-review+
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	If docs needed, set a value
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2019-03-29 13:41:28 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vasiliy Glazov 2019-03-28 09:53:52 UTC

Spec URL: https://raw.githubusercontent.com/Vascom/falkon-pdfreader/master/falkon-pdfreader.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/1177/33801177/falkon-pdfreader-0-0.1.20190118giteefc135.fc31.src.rpm

Description:
PDF reader extension for Falkon using pdf.js.

It allow view PDF documents directly in brouser like Google Chrome.

Comment 1 Vasiliy Glazov 2019-03-28 11:45:13 UTC

Spec URL: https://raw.githubusercontent.com/Vascom/falkon-pdfreader/master/falkon-pdfreader.spec
SRPM URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=33802060

Clean spec.

Comment 2 Vasiliy Glazov 2019-03-28 11:46:27 UTC

Spec URL: https://raw.githubusercontent.com/Vascom/falkon-pdfreader/master/falkon-pdfreader.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/2061/33802061/falkon-pdfreader-0-0.1.20190118giteefc135.fc31.src.rpm

Comment 3 Vitaly 2019-03-28 13:42:45 UTC

I will review this package.

Comment 4 Vitaly 2019-03-28 13:58:08 UTC

Some RPM lint errors detected:

falkon-pdfreader.x86_64: E: no-binary

Comment 5 Vitaly 2019-03-28 14:14:20 UTC

License: OK.
Latest version packaged: OK.
Builds in mock: OK.
No rpmlint errors: "no-binary" is okay for all Falkon plugins.
Conforms to Packaging Guidelines: OK.

Package approved.

Comment 6 Gwyn Ciesla 2019-03-29 13:35:07 UTC

(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/falkon-pdfreader