Bug 1693604 - Review Request: falkon-pdfreader - PDF reader extension for Falkon using pdf.js
Summary: Review Request: falkon-pdfreader - PDF reader extension for Falkon using pdf.js
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Vitaly
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-03-28 09:53 UTC by Vasiliy Glazov
Modified: 2019-03-29 13:41 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2019-03-29 13:41:28 UTC
Type: Bug
Embargoed:
vitaly: fedora-review+

Attachments (Terms of Use)

Description Vasiliy Glazov 2019-03-28 09:53:52 UTC 
Spec URL: https://raw.githubusercontent.com/Vascom/falkon-pdfreader/master/falkon-pdfreader.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/1177/33801177/falkon-pdfreader-0-0.1.20190118giteefc135.fc31.src.rpm

Description:
PDF reader extension for Falkon using pdf.js.

It allow view PDF documents directly in brouser like Google Chrome.
Comment 1 Vasiliy Glazov 2019-03-28 11:45:13 UTC 
Spec URL: https://raw.githubusercontent.com/Vascom/falkon-pdfreader/master/falkon-pdfreader.spec
SRPM URL: https://koji.fedoraproject.org/koji/taskinfo?taskID=33802060

Clean spec.
Comment 2 Vasiliy Glazov 2019-03-28 11:46:27 UTC 
Spec URL: https://raw.githubusercontent.com/Vascom/falkon-pdfreader/master/falkon-pdfreader.spec
SRPM URL: https://kojipkgs.fedoraproject.org//work/tasks/2061/33802061/falkon-pdfreader-0-0.1.20190118giteefc135.fc31.src.rpm
Comment 3 Vitaly 2019-03-28 13:42:45 UTC 
I will review this package.
Comment 4 Vitaly 2019-03-28 13:58:08 UTC 
Some RPM lint errors detected:

falkon-pdfreader.x86_64: E: no-binary
Comment 5 Vitaly 2019-03-28 14:14:20 UTC 
License: OK.
Latest version packaged: OK.
Builds in mock: OK.
No rpmlint errors: "no-binary" is okay for all Falkon plugins.
Conforms to Packaging Guidelines: OK.

Package approved.
Comment 6 Gwyn Ciesla 2019-03-29 13:35:07 UTC 
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/falkon-pdfreader
Note You need to log in before you can comment on or make changes to this bug.